Skip to content

collector: use path/filepath for handling file paths#1245

Merged
SuperQ merged 1 commit intoprometheus:masterfrom
pgier:path-filepath
Feb 5, 2019
Merged

collector: use path/filepath for handling file paths#1245
SuperQ merged 1 commit intoprometheus:masterfrom
pgier:path-filepath

Conversation

@pgier
Copy link
Contributor

@pgier pgier commented Jan 30, 2019

Similar to #1228. Update the remaining collectors to use
'path/filepath' intead of 'path' for manipulating file paths.

Similar to prometheus#1228.  Update the remaining collectors to use
'path/filepath' intead of 'path' for manipulating file paths.

Signed-off-by: Paul Gier <pgier@redhat.com>
Copy link
Contributor

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 2b81bff into prometheus:master Feb 5, 2019
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Similar to prometheus#1228.  Update the remaining collectors to use
'path/filepath' intead of 'path' for manipulating file paths.

Signed-off-by: Paul Gier <pgier@redhat.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Similar to prometheus#1228.  Update the remaining collectors to use
'path/filepath' intead of 'path' for manipulating file paths.

Signed-off-by: Paul Gier <pgier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants