Added feature to get password from Vault#885
Closed
Dmitry-Eremeev wants to merge 1 commit intoprometheus:mainfrom
Closed
Added feature to get password from Vault#885Dmitry-Eremeev wants to merge 1 commit intoprometheus:mainfrom
Dmitry-Eremeev wants to merge 1 commit intoprometheus:mainfrom
Conversation
43130bc to
0f99e4f
Compare
To use the feature we need to set the following options in config section 'client': use_vault = true vault_address = http://<IP_ADDRESS:<IP_PORT> vault_role_id = <ROLE_ID> vault_secret_id = <SECRET_ID> vault_secret_path = <deployments/<UNIT>/dev/user/passwords_yml> vault_secret_mount_path = <secret_v2> credential_name_in_vault_secret = <prometheus_mysql_exporter_database_password> prometheus#883 Signed-off-by: Mitya_Eremeev <mitossvyaz@mail.ru>
0f99e4f to
8bf074d
Compare
SuperQ
reviewed
Nov 8, 2024
Member
SuperQ
left a comment
There was a problem hiding this comment.
Sorry, but I don't think we want to support this. There are far too many secrets managers out there, the code would be unmaintainable.
cristiangreco
added a commit
to grafana/mysqld_exporter
that referenced
this pull request
Nov 8, 2024
Changes: * [CHANGE] Replace logging library go-kit/log with slog prometheus#885 * [FEATURE] Support for prometheus scrape timeout in probe endpoint prometheus#828 * [ENHANCEMENT] Support MySQL 8.4 replicas syntax prometheus#837 * [ENHANCEMENT] Fetch lock time and cpu time from performance schema prometheus#862 * [ENHANCEMENT] Add the instance struct to handle connections prometheus#859 * [ENHANCEMENT] Optimize code by using built-in constants in the standard lib prometheus#844 * [BUGFIX] Fix fetching tmpTables vs tmpDiskTables from performance_schema prometheus#853 * [BUGFIX] Skip SPACE_TYPE column for MariaDB >=10.5 prometheus#860 * [BUGFIX] Fixed parsing of timestamps with non-zero padded days prometheus#841 * [BUGFIX] Fix auto_increment metric collection errors caused by using collation in INFORMATION_SCHEMA searches prometheus#833 * [BUGFIX] Fix race condition in ReloadConfig prometheus#760 * [BUGFIX] Change processlist query to support ONLY_FULL_GROUP_BY sql_mode prometheus#684 * [BUGFIX] replication_applier_status_by_worker requires mysql 8.0 prometheus#683 * [BUGFIX] Update docker registry link in README.md prometheus#813 * [BUGFIX] Fix Docker run command and update documentation for cnf file handling prometheus#843 * [BUGFIX] info_schema_tables: do not collect the sys schema prometheus#879 Signed-off-by: Cristian Greco <cristian@regolo.cc>
Author
|
@cristiangreco
I believe it's typo. |
Contributor
|
@Dmitry-Eremeev yes sorry, I initially referenced #885 instead of #875, but then I fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use the feature we need to set the following options in config section 'client':
use_vault = true
vault_address = http://<IP_ADDRESS:<IP_PORT>
vault_role_id = <ROLE_ID>
vault_secret_id = <SECRET_ID>
vault_secret_path = <deployments//dev/user/passwords_yml> vault_secret_mount_path = <secret_v2>
credential_name_in_vault_secret = <prometheus_mysql_exporter_database_password>
#883