Skip to content

Add pprof links to landing page#196

Merged
SuperQ merged 1 commit intomasterfrom
superq/pprof
Feb 27, 2024
Merged

Add pprof links to landing page#196
SuperQ merged 1 commit intomasterfrom
superq/pprof

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Jan 16, 2024

Make it easier for users to fetch and download pprof data for debugging.

image

Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an excellent idea!
It will make it a lot easier to get profiles from users.

@SuperQ SuperQ requested a review from bboreham January 16, 2024 13:10
@SuperQ
Copy link
Member Author

SuperQ commented Jan 16, 2024

@bboreham What do you think of adding something like this to Prometheus /status?

Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea; I had some suggestions about wording.

What would you think if I said it should offer both pprof.me and flamegraph.com ?

@bboreham
Copy link
Member

What do you think of adding something like this to Prometheus /status?

Sure. I guess the page with most info about memory is /tsdb-status. Suspect what people really want is a top-level breakdown like "40% on samples, 30% on scraping, 20% on remote-write". Which we don't know how to do accurately, but might be able to approximate in a useful way.

@SuperQ SuperQ force-pushed the superq/pprof branch 2 times, most recently from 3f2e63c to 4e1370a Compare January 16, 2024 14:03
Make it easier for users to fetch and download pprof data for debugging.
* Add a link to https://pprof.me for easy sharing.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ merged commit 937b897 into master Feb 27, 2024
@SuperQ SuperQ deleted the superq/pprof branch February 27, 2024 10:46
SuperQ added a commit that referenced this pull request Sep 1, 2024
* [FEATURE] Add pprof links to landing page #196
* [FEATURE] Support listen on vsock #220
* [ENHANCEMENT] Add hints for bash completion #190
* [ENHANCEMENT] Support kingpin.CmdClause as argument #238
* [BUGFIX] Don't swollow listen errors #232

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Sep 1, 2024
SuperQ added a commit that referenced this pull request Sep 3, 2024
* [FEATURE] Add pprof links to landing page #196
* [FEATURE] Support listen on vsock #220
* [ENHANCEMENT] Add hints for bash completion #190
* [ENHANCEMENT] Support kingpin.CmdClause as argument #238
* [BUGFIX] Don't swollow listen errors #232

Signed-off-by: SuperQ <superq@gmail.com>
@dswarbrick
Copy link
Contributor

It might be worth mentioning somewhere in docs that these links will be ineffectual (and most likely just bounce back to the landing page, albeit with additional path suffixes each time) unless the exporter imports net/http/pprof.

@SuperQ
Copy link
Member Author

SuperQ commented Sep 7, 2024

My plan is to add pprof handling to the exporter-toolkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants