expfmt: document NewTextParser as required #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Rudy <webmaster@burgerdev.de>
ArthurSens
approved these changes
Sep 23, 2025
Member
ArthurSens
left a comment
There was a problem hiding this comment.
Thanks, agreed this clarifies expectations!
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Dec 15, 2025
Ref: prometheus/common#842 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Dec 17, 2025
Ref: prometheus/common#842 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Dec 17, 2025
Ref: prometheus/common#842 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Dec 17, 2025
Ref: prometheus/common#842 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Dec 18, 2025
Ref: prometheus/common#842 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Dec 18, 2025
Ref: prometheus/common#842 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to k3s-io/k3s
that referenced
this pull request
Dec 18, 2025
Ref: prometheus/common#842 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zero value is not valid anymore since #808, and #816 introduced the
NewTextParserconstructor. This PR updates theTextParserdocstring to reflect these changes.cc @ywwg