expfmt: only ignore io.EOF errors in TextParse.startOfLine#444
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Feb 20, 2023
Merged
expfmt: only ignore io.EOF errors in TextParse.startOfLine#444roidelapluie merged 1 commit intoprometheus:mainfrom
roidelapluie merged 1 commit intoprometheus:mainfrom
Conversation
beorn7
requested changes
Feb 9, 2023
Member
beorn7
left a comment
There was a problem hiding this comment.
Thank you very much, makes total sense. But could you change the code comment to reflect your reasoning?
Signed-off-by: Andy Bursavich <abursavich@gmail.com>
ad987bb to
d074dea
Compare
Contributor
Author
|
Updated comment. Please take another look. |
beorn7
approved these changes
Feb 10, 2023
Member
beorn7
left a comment
There was a problem hiding this comment.
Thanks again.
Over to @roidelapluie for final approval and merging.
roidelapluie
pushed a commit
to roidelapluie/common
that referenced
this pull request
Feb 20, 2023
The test cases cover the various scenarios that can occur when the TextParser `startOfLine` method encounters an error. The first subtest ensures that the method handles the `io.EOF` error correctly when the input `io.Reader` is empty. The second subtest uses a custom implementation of `io.Reader` to test that `startOfLine` handles errors other than `io.EOF` correctly. See prometheus#444 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 18, 2023
The test cases cover the various scenarios that can occur when the TextParser `startOfLine` method encounters an error. The first subtest ensures that the method handles the `io.EOF` error correctly when the input `io.Reader` is empty. The second subtest uses a custom implementation of `io.Reader` to test that `startOfLine` handles errors other than `io.EOF` correctly. See prometheus#444 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't ignore all errors here, only
io.EOF. If an unexpected connection break just happens to align with the start of a new line, that error shouldn't be suppressed.