Upgrade development dependencies, fix some types#865
Merged
csmarchbanks merged 1 commit intoprometheus:masterfrom Dec 6, 2022
evgenymarkov:upgrade-deps
Merged
Upgrade development dependencies, fix some types#865csmarchbanks merged 1 commit intoprometheus:masterfrom evgenymarkov:upgrade-deps
csmarchbanks merged 1 commit intoprometheus:masterfrom
evgenymarkov:upgrade-deps
Conversation
Signed-off-by: Evgeny Markov <evgenymarkov@yandex.com>
Contributor
Author
|
Sorry, I can't start CI pipeline because of CircleCI restrictions. I was on the territory of the Russian Federation at the time of registration of the CircleCI account. Now they don't let me use CI even though I left Russia 😥 |
csmarchbanks
approved these changes
Dec 6, 2022
Member
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks! I ran the tests locally and everything worked well, annoying that CircleCI isn't possible to run though :(. I didn't find any options for me to run it either without duplicating your branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ✋🏻 I decided to fix one problem in the library, but along the way I ran into another problem - flake8 did not work.
Traceback here
I managed to fix this by updating Flake8 to the latest version. I also updated Mypy to the latest version and it found some typing errors. I fixed it.