updated docs with code to remove default metrics#827
Merged
csmarchbanks merged 1 commit intoprometheus:masterfrom Oct 11, 2022
Merged
updated docs with code to remove default metrics#827csmarchbanks merged 1 commit intoprometheus:masterfrom
csmarchbanks merged 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: Sam Snarr <sssnarr1@gmail.com>
73d381f to
21a7e9a
Compare
csmarchbanks
reviewed
Aug 3, 2022
Member
csmarchbanks
left a comment
There was a problem hiding this comment.
Hello, thank you for the contribution. I am wondering if it is also worthwhile to mention that you can just create a new registry and use that registry instead of the default registry to avoid having the default collectors. Going with the new registry approach will also mean that any future default collectors will not need to be unregistered.
Member
|
Merging this, we can always add the additional suggested documentation later if we want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a while trying to figure out how to remove these default metrics. Im updating the docs with instructions to remove
process,gc, andplatformcollector metrics.Please let me know if my language regarding prometheus is correct, and I will gladly update it