Skip to content

fix var dump#5921

Merged
ehsandeep merged 2 commits intodevfrom
fix_var_dump
Feb 13, 2025
Merged

fix var dump#5921
ehsandeep merged 2 commits intodevfrom
fix_var_dump

Conversation

@dogancanbakir
Copy link
Copy Markdown
Member

@dogancanbakir dogancanbakir commented Dec 18, 2024 •
edited by coderabbitai bot
Loading

Proposed changes

Closes #5916

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by CodeRabbit

  • New Features

    • The variable dumping functionality is now always active, providing consistent output regardless of previous settings.

  • Bug Fixes

    • Simplified control flow in the variable dumping process, ensuring more reliable behavior.

  • Tests

    • Removed test case for variable dumping when disabled; existing tests continue to validate output when enabled.

@dogancanbakir dogancanbakir self-assigned this Dec 18, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 18, 2024 •
edited
Loading

Walkthrough

The pull request modifies the DumpVariables function in the vardump package by removing a conditional check for the EnableVarDump variable. Previously, the function would return an empty string if EnableVarDump was false. Now, the function always proceeds to create a godump.Dumper instance and returns the result of dumping the variables, regardless of the EnableVarDump state. This change simplifies the function's control flow and potentially affects how variable dumping is controlled in the codebase.

Changes

File Change Summary
pkg/protocols/common/utils/vardump/dump.go Removed early return condition based on EnableVarDump in DumpVariables function
pkg/protocols/common/utils/vardump/dump_test.go Removed test case for DumpVariables when EnableVarDump is false

Assessment against linked issues

Objective Addressed Explanation
Fix variable dump functionality broken in v3.3.5 and v3.3.6 [#5916] ✅

Poem

🐰 A rabbit's tale of code so bright,
Variables now dump with all their might!
No more checks to hold them back,
Debugging flows now stay on track.
Hop, hop, hooray for clearer sight! 🔍

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdb5859 and 3ff5116.

📒 Files selected for processing (1)
  • pkg/protocols/common/utils/vardump/dump_test.go (0 hunks)
💤 Files with no reviewable changes (1)
  • pkg/protocols/common/utils/vardump/dump_test.go
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ehsandeep ehsandeep removed the request for review from dwisiswant0 February 13, 2025 11:50
@ehsandeep ehsandeep merged commit 3c825e8 into dev Feb 13, 2025
@ehsandeep ehsandeep deleted the fix_var_dump branch February 13, 2025 11:50
ehsandeep added a commit that referenced this pull request Feb 13, 2025
@Ice3man543 @ehsandeep
@dwisiswant0 @coderabbitai @dogancanbakir @Lercas
feat: added initial live DAST server implementation (#5772)
5f0b7eb 
* feat: added initial live DAST server implementation

* feat: more logging + misc additions

* feat: auth file support enhancements for more complex scenarios + misc

* feat: added io.Reader support to input providers for http

* feat: added stats db to fuzzing + use sdk for dast server + misc

* feat: more additions and enhancements

* misc changes to live server

* misc

* use utils pprof server

* feat: added simpler stats tracking system

* feat: fixed analyzer timeout issue + missing case fix

* misc changes fix

* feat: changed the logics a bit + misc changes and additions

* feat: re-added slope checks + misc

* feat: added baseline measurements for time based checks

* chore(server): fix typos

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix(templates): potential DOM XSS

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix(authx): potential NIL deref

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat: misc review changes

* removed debug logging

* feat: remove existing cookies only

* feat: lint fixes

* misc

* misc text update

* request endpoint update

* feat: added tracking for status code, waf-detection & grouped errors (#6028)

* feat: added tracking for status code, waf-detection & grouped errors

* lint error fixes

* feat: review changes + moving to package + misc

---------

Co-authored-by: sandeep <8293321+ehsandeep@users.noreply.github.com>

* fix var dump (#5921)

* fix var dump

* fix dump test

* Added filename length restriction for debug mode (-srd flag) (#5931)

Co-authored-by: Andrey Matveenko <an.matveenko@vkteam.ru>

* more updates

* Update pkg/output/stats/waf/waf.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

---------

Co-authored-by: sandeep <8293321+ehsandeep@users.noreply.github.com>
Co-authored-by: Dwi Siswanto <25837540+dwisiswant0@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Dogan Can Bakir <65292895+dogancanbakir@users.noreply.github.com>
Co-authored-by: 9flowers <51699499+Lercas@users.noreply.github.com>
Co-authored-by: Andrey Matveenko <an.matveenko@vkteam.ru>
Co-authored-by: Sandeep Singh <sandeep@projectdiscovery.io>
@BrewTestBot BrewTestBot mentioned this pull request Feb 13, 2025
Merged
@blsaccess blsaccess mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] template variable dump works in v3.3.4 but doesn't in 3.3.5 and 3.3.6

2 participants

@dogancanbakir @ehsandeep