Conversation
dogancanbakir
requested changes
Oct 27, 2023
dogancanbakir
approved these changes
Oct 31, 2023
Member
dogancanbakir
left a comment
There was a problem hiding this comment.
LGTM; left comments for further improvement -optional
| } | ||
| } | ||
|
|
||
| if opts.hasStdin() || opts.DomainsFile != "" { |
Member
There was a problem hiding this comment.
Optional: we can make it more readable this way:
if opts.Domain != "" || opts.hasStdin() || opts.DomainsFile != "" {
domains := GetDomains(...)
for _, domain := range domains {
processDomain(domain)
}
}
Mzack9999
approved these changes
Oct 31, 2023
Member
Mzack9999
left a comment
There was a problem hiding this comment.
lgtm!
Listing few possible optimizations:
- Deduping same values in record types (eg via
sliceutil.dedupe(..) - Validate the record types we accept (for example the following command accepts
ccas record type
$ go run . dns projectdiscovery.io -t a,soa,cc,dd
...
{
"soa": [
"alexandra.ns.cloudflare.com",
"alexandra.ns.cloudflare.com",
...
"alexandra.ns.cloudflare.com",
"alexandra.ns.cloudflare.com",
"alexandra.ns.cloudflare.com"
]
}
ehsandeep
pushed a commit
that referenced
this pull request
Nov 7, 2023
ehsandeep
added a commit
that referenced
this pull request
Apr 22, 2024
* Update link for invites * DNS feature and refactoring for V2 (#205) * subdomains * dns * Revert "DNS feature and refactoring for V2 (#205)" (#206) This reverts commit 610a5d4. * Update README.md * workflow updates * template update --------- Co-authored-by: Brendan O'Leary <github@olearycrew.com> Co-authored-by: Mzack9999 <mzack9999@protonmail.com> Co-authored-by: Maxim Bogdanov <muravlion@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes