Skip to content

[dev-gwapi-0.6] drop support for ReferencePolicy#4830

Merged
skriss merged 2 commits intoprojectcontour:dev-gwapi-0.6from
skriss:pr-drop-referencepolicy
Nov 7, 2022
Merged

[dev-gwapi-0.6] drop support for ReferencePolicy#4830
skriss merged 2 commits intoprojectcontour:dev-gwapi-0.6from
skriss:pr-drop-referencepolicy

Conversation

@skriss
Copy link
Copy Markdown
Member

@skriss skriss commented Nov 2, 2022

Drops support for ReferencePolicy, which
has been replaced by ReferenceGrant in
Gateway API.

Updates #4555.

Signed-off-by: Steve Kriss krisss@vmware.com

Leaving as draft until #4738 is unblocked.

skriss added 2 commits November 2, 2022 08:20
@skriss
drop support for ReferencePolicy
6e2e191 
Drops support for ReferencePolicy, which
has been replaced by ReferenceGrant in
Gateway API.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
changelog
42b9381 
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss added the release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. label Nov 2, 2022
@skriss skriss mentioned this pull request Nov 2, 2022
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 2, 2022 •
edited
Loading

Codecov Report

Merging #4830 (42b9381) into main (e700127) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4830      +/-   ##
==========================================
+ Coverage   76.13%   76.27%   +0.13%     
==========================================
  Files         139      139              
  Lines       16917    16886      -31     
==========================================
  Hits        12880    12880              
+ Misses       3782     3752      -30     
+ Partials      255      254       -1
Impacted Files Coverage Δ
cmd/contour/serve.go 12.86% <ø> (+0.05%) ⬆️
internal/dag/cache.go 94.10% <ø> (+1.72%) ⬆️
internal/dag/gatewayapi_processor.go 96.61% <100.00%> (+1.88%) ⬆️
...ovisioner/objects/rbac/clusterrole/cluster_role.go 80.59% <100.00%> (ø)
internal/provisioner/controller/gatewayclass.go 56.98% <0.00%> (+0.23%) ⬆️

sunjayBhatia
sunjayBhatia reviewed Nov 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, when we're able to un-draft this!

@sunjayBhatia sunjayBhatia mentioned this pull request Nov 7, 2022
Closed
@skriss skriss changed the base branch from main to dev-gwapi-0.6 November 7, 2022 17:38
@skriss skriss changed the title drop support for ReferencePolicy [dev-gwapi-0.6] drop support for ReferencePolicy Nov 7, 2022
@skriss skriss marked this pull request as ready for review November 7, 2022 17:39
@skriss skriss requested a review from a team as a code owner November 7, 2022 17:39
@skriss skriss requested review from stevesloka and tsaarni and removed request for a team November 7, 2022 17:39
@skriss
Copy link
Copy Markdown
Member Author

skriss commented Nov 7, 2022 •
edited
Loading

Retargeted this to the dev-gwapi-0.6 branch for now.

@skriss skriss merged commit 6e469c9 into projectcontour:dev-gwapi-0.6 Nov 7, 2022
sunjayBhatia pushed a commit to sunjayBhatia/contour that referenced this pull request Dec 14, 2022
@skriss @sunjayBhatia
drop support for ReferencePolicy (projectcontour#4830)
d2df138 
Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@sunjayBhatia sunjayBhatia mentioned this pull request Dec 14, 2022
Merged
sunjayBhatia added a commit that referenced this pull request Dec 14, 2022
@sunjayBhatia @skriss
Bump Gateway API to 0.6.0-rc.1 (#4929)
e7a8a0d 
* drop support for ReferencePolicy (#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (#4844)

* replace Gateway/Listener Ready conditions with Programmed (#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (#4891)

* Use generics for Gateway API pointer helpers (#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes #4555 
Fixes #4699 
Fixes #4848 

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
@skriss skriss deleted the pr-drop-referencepolicy branch January 31, 2023 19:19
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
@sunjayBhatia @skriss @yangyy93
Bump Gateway API to 0.6.0-rc.1 (projectcontour#4929)
c703d01 
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
@sunjayBhatia @skriss @yangyy93
Bump Gateway API to 0.6.0-rc.1 (projectcontour#4929)
b460e03 
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this pull request Feb 28, 2023
@sunjayBhatia @skriss @vmw-yingy
Bump Gateway API to 0.6.0-rc.1 (projectcontour#4929)
4980d1a 
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555 
Fixes projectcontour#4699 
Fixes projectcontour#4848 

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni was automatically assigned from projectcontour/maintainers

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka was automatically assigned from projectcontour/maintainers

Assignees

No one assigned

Labels

release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skriss @sunjayBhatia