Skip to content

Workaround for issue #4104#5881

Closed
ghjansen wants to merge 2 commits into
processing:masterfrom
ghjansen:issue4104
Closed

Workaround for issue #4104#5881
ghjansen wants to merge 2 commits into
processing:masterfrom
ghjansen:issue4104

Conversation

@ghjansen

Copy link
Copy Markdown

Conditional control of FBO layer, based on environment settings.
Looking forward for feedback on any adjustment required.

More info:
Issue #4104
Comment explainig the patch

Conditional control of FBO layer, based on environment settings. Fixes processing#4104 .
@commonpike

Copy link
Copy Markdown

Without this, my mac powerbooks cant use P2D or P3D. I applied this patch and magically solved the issue without noticeable side effects.

Fwiw, here's a writeup of how I did that
https://stackoverflow.com/questions/57943895/processing-apply-core-patch-and-compile

@ghjansen

Copy link
Copy Markdown
Author

I am happy to know that it helped @commonpike . Thank you for sharing!
Please let me know if you notice anything wrong while using it.
I upvoted your solution in SO.

@benfry

benfry commented Oct 3, 2019

Copy link
Copy Markdown
Contributor

We can't make use of sun.java2d.* classes because they're non-standard. If this is the only way to do it, these methods would need to be called via reflection, so that it can degrade gracefully if the sun.java2d package (or a specific class) is not available.

Reflective access to GraphicsConfiguration for FBO layer control. Issue processing#4104.
@ghjansen

ghjansen commented Oct 6, 2019

Copy link
Copy Markdown
Author

@benfry understood. Thank you for your feedback!
I don't know yet a different way of doing this.
ce575e9 now uses reflection to handle sun.java2d.*.
Please, let me know if you think it can degrade gracefully enough this way.
Also, I'm available for hire. Is there any interest?

benfry added a commit to benfry/processing4 that referenced this pull request Oct 7, 2019
@benfry

benfry commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

Thanks for the fix, really appreciate it. I've incorporated a version of it over here: processing/processing4@269f626 for Processing 4.x.

@codeanticode will want to fix it up later since there's already FBO enabled/disabled code in there, but at least we have the workaround for now.

@benfry benfry closed this Oct 7, 2019
@ghjansen

ghjansen commented Oct 7, 2019

Copy link
Copy Markdown
Author

@benfry nice!
@commonpike do you mind to test with the latest changes? (ce575e9)

@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants