Add console hiding button#5115
Merged
Merged
Conversation
Contributor
|
I think we could probably incorporate this if you tweak it a bit for the just-added “clipboard” icon in the status bar. I'd put this to the right of it (but in a separate |
Contributor
Author
|
@benfry Sure, will have a look over the next few days if possible. |
31033fd to
6145e7d
Compare
Contributor
Author
|
I've merged the code for the two buttons so that both display as a Unicode character centred in a square, which can then be highlighted nicely on hover. All seems to work fine. |
Also made the existing copy-message button consistent.
6145e7d to
d0e016b
Compare
Contributor
|
Thanks; giving this a shot. |
benfry
added a commit
that referenced
this pull request
Jan 18, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #970. Gives a bit more room to code on a smaller screen. I haven't automatically unhidden it when the sketch starts since that's just bothering the user and the status bar still changes colour on exceptions. Also, I'm not leaving space for the
RIGHT_MARGINin EditorStatus; should I be? (N.B. you have push access to my PR branches, feel free to make trivial changes to constants/text etc. rather than describing them to me when that's convenient).Also (mouseExited listener) fixed a bug where if you moved your mouse off an URL in the status bar vertically it would stay the hovered-over color because it only cares about
mouseX.