Avoid missing check when gaining focus from a Sketch Disappeared popup#4808
Closed
joelmoniz wants to merge 1 commit into
Closed
Avoid missing check when gaining focus from a Sketch Disappeared popup#4808joelmoniz wants to merge 1 commit into
joelmoniz wants to merge 1 commit into
Conversation
Contributor
|
@JakubValtar another to review for the |
Contributor
|
Fixed with b3763a8 |
benfry
added a commit
that referenced
this pull request
Jan 18, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #4805, which was happening because the
ensureExistence()method was called each time the window gained focus: since closing the popup causes the window gains focus, this check and the accompanying warning dialogs would repeat ad infinitum.In detail, what caused the bug is as follows:
ensureExistence()PS: I used the name of the JDialog since it seemed liked the simplest option- to avoid making changes to the structure of
ensureExistence()(such as by returning false or re-throwing the error if the sketch does not exist), since several other methods call it, and I'll be happy to update this PR if another way of doing this might be better.