Skip to content

fix: render tuple functions#5783

Merged
jacek-prisma merged 3 commits intomainfrom
fix/render-tuple-functions
Feb 24, 2026
Merged

fix: render tuple functions#5783
jacek-prisma merged 3 commits intomainfrom
fix/render-tuple-functions

Conversation

@jacek-prisma
Copy link
Copy Markdown
Contributor

@jacek-prisma jacek-prisma commented Feb 24, 2026 •
edited
Loading

TML-1922

Enables the query compiler to render tuples of parameters wrapped in function calls. Needed for properly rendering ? IN (LOWER(?), LOWER(?)).

Client PR: prisma/prisma#29243

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 24, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1

Comparing fix/render-tuple-functions (bc8c328) with main (abbfa42)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2026 •
edited
Loading

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.505MiB 3.497MiB 7.782KiB
Postgres (gzip) 1.141MiB 1.143MiB -2.066KiB
Postgres (size-optimized) 1.766MiB 1.764MiB 2.163KiB
Postgres (size-optimized, gzip) 694.682KiB 694.161KiB 534.000B
Mysql 3.457MiB 3.449MiB 7.976KiB
Mysql (gzip) 1.127MiB 1.125MiB 2.330KiB
Mysql (size-optimized) 1.736MiB 1.734MiB 1.695KiB
Mysql (size-optimized, gzip) 683.704KiB 682.603KiB 1.101KiB
Sqlite 3.376MiB 3.368MiB 7.797KiB
Sqlite (gzip) 1.098MiB 1.098MiB 389.000B
Sqlite (size-optimized) 1.692MiB 1.690MiB 1.770KiB
Sqlite (size-optimized, gzip) 667.058KiB 666.779KiB 286.000B
SQL Server 3.598MiB 3.591MiB 6.919KiB
SQL Server (gzip) 1.162MiB 1.161MiB 479.000B
SQL Server (size-optimized) 1.766MiB 1.764MiB 1.864KiB
SQL Server (size-optimized, gzip) 697.909KiB 697.268KiB 656.000B
CockroachDB 3.555MiB 3.547MiB 7.785KiB
CockroachDB (gzip) 1.160MiB 1.162MiB -2.145KiB
CockroachDB (size-optimized) 1.791MiB 1.789MiB 2.163KiB
CockroachDB (size-optimized, gzip) 704.941KiB 704.331KiB 625.000B

@aqrln aqrln added this to the 7.5.0 milestone Feb 24, 2026
aqrln
aqrln reviewed Feb 24, 2026
View reviewed changes
aqrln
aqrln approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a minor comment unrelated to the pr

@jacek-prisma jacek-prisma merged commit e32e01e into main Feb 24, 2026
99 checks passed
@jacek-prisma jacek-prisma deleted the fix/render-tuple-functions branch February 24, 2026 16:09
dimsssss pushed a commit to dimsssss/prisma-engines that referenced this pull request Feb 26, 2026
@jacek-prisma @dimsssss
fix: render tuple functions (prisma#5783)
3a6e03c 
[TML-1922](https://linear.app/prisma-company/issue/TML-1922/fix-case-insensitive-in-regression)

Enables the query compiler to render tuples of parameters wrapped in
function calls. Needed for properly rendering `? IN (LOWER(?),
LOWER(?))`.

Client PR: prisma/prisma#29243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aqrln aqrln aqrln approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jacek-prisma @aqrln