Merged
Conversation
CodSpeed Performance ReportMerging #5092 will not alter performanceComparing Summary
|
Contributor
WASM Query Engine file Size
|
jkomyno
reviewed
Dec 18, 2024
| .expect("Expected string ID but got something else."); | ||
|
|
||
| // Validate that this is a valid ULID value | ||
| assert!(ulid::Ulid::from_string(ulid).is_ok()); |
Contributor
There was a problem hiding this comment.
Please, add an explicit test to ensure we emit 26-char-long ULIDs, thanks
jkomyno
approved these changes
Dec 18, 2024
aqrln
reviewed
Dec 19, 2024
|
Also, does this store the ULID in binary format? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the 26 character Crockford's base32 String representation.
Example ULIDs generated in tests:
01JFCSRJMJX6DWQ3T79T3W4HHK01JFCSSM6ADDD95NPRAXP1YJBC01JFCST0RA1RCJTNBTK4MTJ25J01JFCST8GMP5G6BGX9PJJNQF67Closes prisma/prisma#13679
Closes ORM-448