Skip to content

fix: handle native types for joined queries#4546

Merged
Weakky merged 6 commits intomainfrom
fix/json-native-type
Dec 18, 2023
Merged

fix: handle native types for joined queries#4546
Weakky merged 6 commits intomainfrom
fix/json-native-type

Conversation

@Weakky
Copy link
Copy Markdown
Contributor

@Weakky Weakky commented Dec 8, 2023

Overview

fixes prisma/prisma#22293

Note: Money type is always casted as numeric to avoid having to parse string currencies which depend on locales and can take highly variable shapes. context: have a look at this table 🤒 https://stackoverflow.com/q/71908140

@Weakky Weakky requested a review from a team as a code owner December 8, 2023 11:07
@Weakky Weakky requested review from Druue and jkomyno and removed request for a team December 8, 2023 11:07
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 8, 2023

CodSpeed Performance Report

Merging #4546 will not alter performance

Comparing fix/json-native-type (975bc96) with main (91dff98)

Summary

✅ 11 untouched benchmarks

@Weakky Weakky force-pushed the fix/json-native-type branch from 44c2cbc to b6ce565 Compare December 8, 2023 14:22
@janpio janpio added this to the 5.8.0 milestone Dec 8, 2023
@Weakky Weakky force-pushed the fix/json-native-type branch from d6bda8e to a61155a Compare December 14, 2023 13:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 14, 2023

WASM Size

Engine This PR Base branch Diff
WASM 3.183MiB 3.184MiB -1.192KiB
WASM (gzip) 1.198MiB 1.199MiB -963.000B

@Weakky Weakky merged commit 2592cb6 into main Dec 18, 2023
@Weakky Weakky deleted the fix/json-native-type branch December 18, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent column data: Unexpected conversion failure from String to datetime. Reason: $trailing input

5 participants