me: never try to migrate a column with @default(dbgenerated())#3153
Merged
me: never try to migrate a column with @default(dbgenerated())#3153
Conversation
cc31ec2 to
e825b74
Compare
e825b74 to
587ec25
Compare
do4gr
reviewed
Aug 29, 2022
| let sql = r#" | ||
| CREATE TABLE "table" ( | ||
| "id" TEXT NOT NULL, | ||
| "hereBeDragons" TEXT NOT NULL GENERATED ALWAYS AS ('this row ID is: '::text || "id") STORED, |
Member
There was a problem hiding this comment.
Why do you test on generated columns specifically?
Contributor
Author
There was a problem hiding this comment.
it's the example from the issue
do4gr
approved these changes
Aug 29, 2022
pimeys
approved these changes
Aug 29, 2022
| "chrono", | ||
| "datamodel-connector", | ||
| "diagnostics", | ||
| "dissimilar", |
Contributor
There was a problem hiding this comment.
Somebody pushed a faulty lock file, I'm getting the same diff with my branch...
Contributor
Author
There was a problem hiding this comment.
I think that somebody is me, sowwy
aqrln
added a commit
that referenced
this pull request
Apr 26, 2024
Empty `dbgenerated()` was fixed for supported types in #3153 but that PR lacked the corresponding changes for the unsupported types which this commit adds.
Druue
pushed a commit
that referenced
this pull request
Apr 26, 2024
Empty `dbgenerated()` was fixed for supported types in #3153 but that PR lacked the corresponding changes for the unsupported types which this commit adds.
Druue
added a commit
that referenced
this pull request
Apr 30, 2024
* se: support empty `dbgenerated()` in columns of unsupported types Empty `dbgenerated()` was fixed for supported types in #3153 but that PR lacked the corresponding changes for the unsupported types which this commit adds. --------- Co-authored-by: Alexey Orlenko <alex@aqrln.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes prisma/prisma#14799