Merged
Conversation
15b36c4 to
fbfb264
Compare
If the index is pointing to a same column than another index, but they have different names, we detected drift.
fbfb264 to
36b868f
Compare
tomhoule
reviewed
May 7, 2021
| let number_of_identical_indexes = self | ||
| .previous_indexes() | ||
| .filter(|right| left.column_names() == right.column_names() && left.index_type() == right.index_type()) | ||
| .fold(0, |acc, _| acc + 1); |
Contributor
There was a problem hiding this comment.
I think there is a .count() method on iterators that does the same thing.
Contributor
Author
There was a problem hiding this comment.
rust-analyzer thought not. but you're right.
Druue
pushed a commit
that referenced
this pull request
May 24, 2024
fixes prisma/prisma#23043 based on #1904
Druue
pushed a commit
that referenced
this pull request
May 28, 2024
fixes prisma/prisma#23043 based on #1904
Druue
pushed a commit
that referenced
this pull request
May 30, 2024
fixes prisma/prisma#23043 based on #1904
Druue
pushed a commit
that referenced
this pull request
May 30, 2024
…in migrations related: - prisma/prisma#6873 - #1904 - #4885
Druue
added a commit
that referenced
this pull request
May 31, 2024
* Fix drift when FKs have same columns * Updated FK filtering to use hashset of seen fks fixes prisma/prisma#23043 related #1904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the index is pointing to a same column than another index, but they
have different names, we detected drift.
Closes: prisma/prisma#6873