Skip to content

improvement(migrate): better error message for nativeTypes#4188

Merged
Jolg42 merged 1 commit intomasterfrom
pr/migrate-nativeTypes
Nov 9, 2020
Merged

improvement(migrate): better error message for nativeTypes#4188
Jolg42 merged 1 commit intomasterfrom
pr/migrate-nativeTypes

Conversation

@Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Nov 9, 2020 •
edited
Loading

Closes #4186

Before

j42@Pluto ~/D/p/s/p/m/f/mini> ../../src/bin.ts push --preview-feature

Prisma schema loaded from prisma/schema.prisma
Response "Some of the requested preview features are not yet allowed in migration engine. Please remove them from your data model before using migrations. (blocked: `nativeTypes`)"
Got result for unknown id undefined
Oops, an unexpected error occured!
Error in migration engine: Nov 09 12:16:30.753  INFO migration_engine: Starting migration engine RPC server git_hash="a624a6628b9e5e453bb8f8cb0460e233a3a97e62"

Please help us improve Prisma by submitting an error report.
Error reports never contain personal or other sensitive information.
Learn more: https://pris.ly/d/telemetry

✖ Submit error report › Yes
✖ Would you like to create a Github issue? › Yes

After

j42@Pluto ~/D/p/s/p/migrate> ./src/bin.ts push --preview-feature --schema=fixtures/mini/prisma/schema.prisma
Prisma schema loaded from fixtures/mini/prisma/schema.prisma
Error: "nativeTypes" preview feature is not supoorted yet. Remove it from your schema to use Prisma Migrate.
j42@Pluto ~/D/p/s/p/migrate>

@Jolg42 Jolg42 requested a review from timsuchanek November 9, 2020 11:09
@Jolg42 Jolg42 added this to the Release 2.11.0 milestone Nov 9, 2020
timsuchanek
timsuchanek approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@timsuchanek timsuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Jolg42 Jolg42 merged commit ef792cd into master Nov 9, 2020
@Jolg42 Jolg42 deleted the pr/migrate-nativeTypes branch November 9, 2020 11:27
Jolg42 added a commit that referenced this pull request Nov 9, 2020
@Jolg42
Merge branch 'master' into pr/migrate
317f9e7 
* master:
  fix: bump engines (#4192)
  fix: finish transaction stabilization (#4191)
  fix: make getErrorMessageWithLink more resilient
  fix(client): fix #4083 (#4189)
  chore(deps): update studio to v0.310.0 (#4187)
  chore: bump @prisma/bar
  improvement(migrate): better error message for nativeTypes (#4188)
  chore(migrate): fix internal migrate tryLoadEnvs for dev
  chore: update pnpm-lock [skip ci]
  chore(deps): update devdependencies (non-major)
  feat(client): add types to middleware params.model (#4161)

# Conflicts:
#	src/packages/migrate/src/bin.ts
#	src/packages/migrate/src/utils/ensureDatabaseExists.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timsuchanek timsuchanek timsuchanek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 2.11.0

Development

Successfully merging this pull request may close these issues.

Improve error when using prisma migrate --experimental with native types

2 participants

@Jolg42 @timsuchanek