fix: support joins that do not require strict equality by jacek-prisma · Pull Request #29251 · prisma/prisma

jacek-prisma · 2026-02-25T14:57:18Z

Adds support for a new canAssumeStrictEquality flag used for in-memory joins. When it's set to false, we infer the type of the key present on the parent rows and inject casts for children rows. Fixes some MySQL edge cases.

Fixes #29122

Engine PR: prisma/prisma-engines#5785

Summary by CodeRabbit

Bug Fixes
- Improved join key matching with optional per-field value mapping/type casting and a new flag to control strict-equality assumptions.
- Standardized validation error identifiers to camelCase for more consistent error reporting.
Tests
- Added MySQL-only functional tests for view relations with large BigInt keys.
Chores
- Updated internal engine/tooling version references.

coderabbitai · 2026-02-25T14:57:44Z

Walkthrough

Adds optional per-field mappers for record key generation and threads a new canAssumeStrictEquality flag through query planning and interpretation to enable inferred key casts. Renames validation error property to camelCase. Adds MySQL BIGINT view-relation functional tests and updates sample query plans and some dependency versions.

Changes

Cohort / File(s)	Summary
Record key generation `packages/client-engine-runtime/src/interpreter/in-memory-processing.ts`	`getRecordKey` signature extended to accept `mappers?: ((value: unknown)=>unknown)[]`; applies per-field mapper (preserving null) when present before JSON-stringifying the key.
Query interpreter & key-casting logic `packages/client-engine-runtime/src/interpreter/query-interpreter.ts`	`attachChildrenToParents` gains `canAssumeStrictEquality: boolean`; adds `inferKeyCasts(rows, keys)` returning per-key cast functions; uses mappers when strict equality cannot be assumed; refactors parent/child key handling.
Query plan shape & errors `packages/client-engine-runtime/src/query-plan.ts`	`QueryPlanNode` join `args` now include `canAssumeStrictEquality: boolean`. `ValidationError` variants renamed field `error_identifier` → `errorIdentifier`.
Validation helpers `packages/client-engine-runtime/src/interpreter/validation.ts`	Switched to `error.errorIdentifier` in `renderMessage` and `getErrorCode`; logic unchanged otherwise.
Bench sample plans `packages/client-engine-runtime/bench/sample-query-plans.ts`	Added `canAssumeStrictEquality: true` across multiple join nodes in sample/benchmark plans.
Functional tests (MySQL BIGINT view relation) `packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/_matrix.ts`, `packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/prisma/_schema.ts`, `packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/tests.ts`	Adds MySQL-only test matrix, Prisma schema with a view exposing BIGINT keys, and regression test validating view-relation behavior with bigint keys.
Dependency bumps `packages/*/package.json` (multiple) `packages/client-generator-js/package.json`, `packages/client-generator-ts/package.json`, `packages/client/package.json`, `packages/engines/package.json`, `packages/fetch-engine/package.json`, `packages/internals/package.json`, `packages/migrate/package.json`, `packages/schema-files-loader/package.json`	Bumped various `@prisma/*` engine/schema dependency versions to `7.5.0-10...` across several package.json files; no code behavior changes.

Suggested labels

lgtm

Suggested reviewers

aqrln

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: support joins that do not require strict equality' accurately describes the main change enabling non-strict equality joins for type mismatches.
Linked Issues check	✅ Passed	The PR implements all key objectives: adds canAssumeStrictEquality flag for in-memory joins, infers key type casts when strict equality cannot be assumed, and enables correct relation matching despite database type mismatches to fix issue `#29122`.
Out of Scope Changes check	✅ Passed	Besides the main scope, the PR includes error_identifier to errorIdentifier renaming in query-plan.ts and validation.ts, which is tangential to the join equality feature but supports the overall schema consistency improvements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/strict-equality-joins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c33e8f8 and 8abc803.

📒 Files selected for processing (6)

packages/client-engine-runtime/src/interpreter/in-memory-processing.ts
packages/client-engine-runtime/src/interpreter/query-interpreter.ts
packages/client-engine-runtime/src/query-plan.ts
packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/_matrix.ts
packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/prisma/_schema.ts
packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/tests.ts

packages/client-engine-runtime/src/interpreter/query-interpreter.ts

packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/tests.ts

github-actions · 2026-02-25T15:11:58Z

size-limit report 📦

Path	Size
packages/client/runtime/index-browser.js	2.23 KB (0%)
packages/client/runtime/index-browser.d.ts	3.28 KB (0%)
packages/cli/build/index.js	2.5 MB (+0.01% 🔺)
packages/client/prisma-client-0.0.0.tgz	26.81 MB (+0.02% 🔺)
packages/cli/prisma-0.0.0.tgz	12.84 MB (+0.02% 🔺)
packages/bundle-size/da-workers-libsql/output.tgz	1.33 MB (+0.01% 🔺)
packages/bundle-size/da-workers-neon/output.tgz	1.39 MB (+0.02% 🔺)
packages/bundle-size/da-workers-pg/output.tgz	1.38 MB (+0.02% 🔺)
packages/bundle-size/da-workers-planetscale/output.tgz	1.33 MB (+0.03% 🔺)
packages/bundle-size/da-workers-d1/output.tgz	1.3 MB (+0.01% 🔺)

github-actions · 2026-02-25T15:31:57Z

🟢 All good, this PR is no longer uses custom engine.

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8abc803 and f1af039.

📒 Files selected for processing (3)

packages/client-engine-runtime/bench/sample-query-plans.ts
packages/client-engine-runtime/src/interpreter/in-memory-processing.ts
packages/client/tests/functional/issues/29122-mysql-bigint-view-relation/tests.ts

packages/client-engine-runtime/src/interpreter/in-memory-processing.ts

packages/client-engine-runtime/src/interpreter/query-interpreter.ts

[TML-1868](https://linear.app/prisma-company/issue/TML-1868/fix-mysql-bigint-relation-issue) /prisma-branch fix/strict-equality-joins Client PR: prisma/prisma#29251  ## Summary by CodeRabbit * **New Features** * Joins now carry a flag to enable stricter equality assumptions when supported, improving cross-database join handling. * Validation expressions include richer context for clearer error reporting. * **Chores** * Connector implementations updated to advertise support for strict-equality joins where applicable, enabling optimized query generation.

…0f7ba866919

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86ea036 and 61e8d9c.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (9)

packages/client-engine-runtime/src/interpreter/query-interpreter.ts
packages/client-generator-js/package.json
packages/client-generator-ts/package.json
packages/client/package.json
packages/engines/package.json
packages/fetch-engine/package.json
packages/internals/package.json
packages/migrate/package.json
packages/schema-files-loader/package.json

packages/client-engine-runtime/src/interpreter/query-interpreter.ts

[TML-1868](https://linear.app/prisma-company/issue/TML-1868/fix-mysql-bigint-relation-issue) Adds support for a new `canAssumeStrictEquality` flag used for in-memory joins. When it's set to false, we infer the type of the key present on the parent rows and inject casts for children rows. Fixes some MySQL edge cases. Fixes #29122 Engine PR: prisma/prisma-engines#5785  ## Summary by CodeRabbit * **Bug Fixes** * Improved join key matching with optional per-field value mapping/type casting and a new flag to control strict-equality assumptions. * Standardized validation error identifiers to camelCase for more consistent error reporting. * **Tests** * Added MySQL-only functional tests for view relations with large BigInt keys. * **Chores** * Updated internal engine/tooling version references.  --------- Co-authored-by: Prismo <prismabots@gmail.com>

fix: support joins that do not require strict equality

8abc803

jacek-prisma mentioned this pull request Feb 25, 2026

feat: return a can_assume_strict_equality for in-memory joins prisma/prisma-engines#5785

Merged

coderabbitai bot reviewed Feb 25, 2026

View reviewed changes

chore: address a few minor issues

f1af039

coderabbitai bot reviewed Feb 25, 2026

View reviewed changes

packages/client-engine-runtime/src/interpreter/in-memory-processing.ts Show resolved Hide resolved

fix: camel case error_identifier

86ea036

aqrln reviewed Feb 27, 2026

View reviewed changes

packages/client-engine-runtime/src/interpreter/query-interpreter.ts Outdated Show resolved Hide resolved

prisma-bot and others added 2 commits February 27, 2026 08:58

chore(deps): update engines to 7.5.0-10.94a226be1cf2967af2541cca5529f…

b33187a

…0f7ba866919

chore: address comment

61e8d9c

coderabbitai bot reviewed Feb 27, 2026

View reviewed changes

packages/client-engine-runtime/src/interpreter/query-interpreter.ts Show resolved Hide resolved

jacek-prisma requested a review from aqrln February 27, 2026 11:46

aqrln approved these changes Feb 27, 2026

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2026

jacek-prisma merged commit 90d119c into main Feb 27, 2026
494 of 499 checks passed

jacek-prisma deleted the fix/strict-equality-joins branch February 27, 2026 13:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: support joins that do not require strict equality#29251

fix: support joins that do not require strict equality#29251
jacek-prisma merged 5 commits intomainfrom
fix/strict-equality-joins

jacek-prisma commented Feb 25, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 25, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jacek-prisma commented Feb 25, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

github-actions bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jacek-prisma commented Feb 25, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading

github-actions bot commented Feb 25, 2026 •

edited

Loading