fix(client): apply result extensions for nested and fluent relations by LucianBuzzo · Pull Request #29218 · prisma/prisma

LucianBuzzo · 2026-02-18T06:56:32Z

Result extensions were always applied using the root request model/args in getPrismaClient._request. That works for regular top-level results, but fluent relation calls use dataPath unpacking first, so the payload handed to applyAllResultExtensions is already the nested relation object/list. In that case, walking extensions with the root model context skips nested computed fields (for example post extensions on user.findUnique(...).posts()).

This change resolves the effective extension context from dataPath before applying result extensions. The new resolveResultExtensionContext helper strips select/include tokens, follows relation fields through runtimeDataModel, and derives the matching nested args branch. If resolution is invalid it safely falls back to the root context.

I also added regression coverage for nested reads/writes and fluent relation calls in functional extensions tests, plus focused unit tests for context resolution (including fluent-style unwrapped payload behavior).

Summary by CodeRabbit

New Features
- Result extensions can compute and expose additional nested fields (e.g., derived labels) on related models.
Improvements
- More reliable resolution of nested model context for result extensions across fluent select/include paths, including when relation fields are named "select" or "include".
- Extension application now uses resolved nested context for more accurate behavior in nested queries.
Bug Fixes
- Prevents dropped nested selections when selector segments appear in relation paths.
Tests
- Added comprehensive unit and functional tests covering nested resolution and computed-field propagation.

…esults Result extensions were always applied using the root request model/args in getPrismaClient._request. That works for regular top-level results, but fluent relation calls use dataPath unpacking first, so the payload handed to applyAllResultExtensions is already the nested relation object/list. In that case, walking extensions with the root model context skips nested computed fields (for example post extensions on user.findUnique(...).posts()). This change resolves the effective extension context from dataPath before applying result extensions. The new resolveResultExtensionContext helper strips select/include tokens, follows relation fields through runtimeDataModel, and derives the matching nested args branch. If resolution is invalid it safely falls back to the root context. I also added regression coverage for nested reads/writes and fluent relation calls in functional extensions tests, plus focused unit tests for context resolution (including fluent-style unwrapped payload behavior). Validation run:\n- pnpm --filter @prisma/client test -- src/runtime/core/extensions\n- pnpm --filter @prisma/client test:functional:code --adapter js_better_sqlite3 extensions

CLAassistant · 2026-02-18T06:56:37Z

All committers have signed the CLA.

coderabbitai · 2026-02-18T06:56:55Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds a resolver that derives result-extension context from fluent-style dataPath (alternating select/include hops), integrates it into the client request flow to compute modelName/args for result extensions, and adds unit and functional tests plus a documentation note about dataPath semantics and testing/runtime considerations.

Changes

Cohort / File(s)	Summary
Documentation `AGENTS.md`	Documents that the Fluent API builds `dataPath` as alternating `['select'
Result Extension Resolver `packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts`	New module `resolveResultExtensionContext` that parses `dataPath` into relation hops, traverses `runtimeDataModel`, and resolves `{ modelName, args }` for applying result extensions; returns root context or throws on invalid relation field.
Resolver Unit Tests `packages/client/src/runtime/core/extensions/resolve-result-extension-context.test.ts`	Adds comprehensive tests for empty/root `dataPath`, single- and multi-hop fluent `select`/`include` resolution, missing-relation errors, defaulting nested args, literal relation fields named `select`/`include`, and applying result extensions to unwrapped fluent results.
Runtime Integration `packages/client/src/runtime/getPrismaClient.ts`	Imports and invokes `resolveResultExtensionContext` in the request flow when a model exists; computes `extensionContext` from `dataPath`, `modelName`, `args`, and `runtimeDataModel`, and applies result extensions using `extensionContext.modelName`/`args` instead of `requestParams`.
Functional Tests (result extensions) `packages/client/tests/functional/extensions/result.ts`	Adds functional tests that register result-layer extensions computing nested fields (e.g., `user.fullName`, `post.postLabel`) and validate behavior across includes/selects and nested create/update shapes, exercising fluent and nested interactions.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: applying result extensions for nested and fluent relations, which is directly supported by the code changes across all modified files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 3

packages/client/src/runtime/core/extensions/resolveResultExtensionContext.test.ts

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts

- Rename new resolver files to kebab-case\n- Update imports to new filenames\n- Add doc comment to exported resolveResultExtensionContext

coderabbitai

Actionable comments posted: 1

packages/client/src/runtime/core/extensions/resolve-result-extension-context.test.ts

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts

coderabbitai

Actionable comments posted: 1

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts

coderabbitai

Actionable comments posted: 1

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts

LucianBuzzo · 2026-02-18T14:56:27Z

@jacek-prisma I've applied your suggestions and fixed a minor typescript error in a test file. Should be good to go now.

…29218) Result extensions were always applied using the root request model/args in getPrismaClient._request. That works for regular top-level results, but fluent relation calls use dataPath unpacking first, so the payload handed to applyAllResultExtensions is already the nested relation object/list. In that case, walking extensions with the root model context skips nested computed fields (for example post extensions on user.findUnique(...).posts()). This change resolves the effective extension context from dataPath before applying result extensions. The new resolveResultExtensionContext helper strips select/include tokens, follows relation fields through runtimeDataModel, and derives the matching nested args branch. If resolution is invalid it safely falls back to the root context. I also added regression coverage for nested reads/writes and fluent relation calls in functional extensions tests, plus focused unit tests for context resolution (including fluent-style unwrapped payload behavior).  ## Summary by CodeRabbit * **New Features** * Result extensions can compute and expose additional nested fields (e.g., derived labels) on related models. * **Improvements** * More reliable resolution of nested model context for result extensions across fluent select/include paths, including when relation fields are named "select" or "include". * Extension application now uses resolved nested context for more accurate behavior in nested queries. * **Bug Fixes** * Prevents dropped nested selections when selector segments appear in relation paths. * **Tests** * Added comprehensive unit and functional tests covering nested resolution and computed-field propagation.

coderabbitai bot reviewed Feb 18, 2026

View reviewed changes

chore(client): address CodeRabbit naming and docs suggestions

d7414e4

- Rename new resolver files to kebab-case\n- Update imports to new filenames\n- Add doc comment to exported resolveResultExtensionContext

coderabbitai bot reviewed Feb 18, 2026

View reviewed changes

packages/client/src/runtime/core/extensions/resolve-result-extension-context.test.ts Outdated Show resolved Hide resolved

jacek-prisma reviewed Feb 18, 2026

View reviewed changes

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts Outdated Show resolved Hide resolved

jacek-prisma reviewed Feb 18, 2026

View reviewed changes

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts Outdated Show resolved Hide resolved

LucianBuzzo added 2 commits February 18, 2026 11:22

fix(client): handle select/include relation names in extension context

192b0bf

fix(client): throw on invalid relation segments in extension context

381bb39

coderabbitai bot reviewed Feb 18, 2026

View reviewed changes

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts Show resolved Hide resolved

jacek-prisma reviewed Feb 18, 2026

View reviewed changes

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts Show resolved Hide resolved

LucianBuzzo added 3 commits February 18, 2026 14:06

docs(client): clarify extension context fallback and throw contract

38c2ff0

refactor(client): use type guard for nested relation args

0e16a63

test(client): use null-safe assertions for extension results

513099d

coderabbitai bot reviewed Feb 18, 2026

View reviewed changes

packages/client/src/runtime/core/extensions/resolve-result-extension-context.ts Show resolved Hide resolved

jacek-prisma approved these changes Feb 18, 2026

View reviewed changes

jacek-prisma merged commit 77bfc96 into prisma:main Feb 18, 2026
253 of 254 checks passed

Conversation

LucianBuzzo commented Feb 18, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

CLAassistant commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LucianBuzzo commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LucianBuzzo commented Feb 18, 2026 •

edited by coderabbitai bot

Loading

CLAassistant commented Feb 18, 2026 •

edited

Loading

coderabbitai bot commented Feb 18, 2026 •

edited

Loading