fix: handle parameterised values in the cursor by jacek-prisma · Pull Request #29184 · prisma/prisma

jacek-prisma · 2026-02-13T12:18:34Z

TML-1902
Fixes #29176

Summary by CodeRabbit

Bug Fixes
- Fixed cursor-based pagination to correctly evaluate dynamic cursor and nested processing parameters during in-memory query processing.
Tests
- Added functional tests validating composite cursor pagination and related behavior.
Chores
- Tightened the pagination cursor type for stronger type-safety in client runtime.

coderabbitai · 2026-02-13T12:18:57Z

Walkthrough

Added evaluation of in-memory processing parameters in the query interpreter and changed Pagination.cursor type to Record<string, unknown> | null. Added functional tests (matrix, Prisma schema, and test) validating composite cursor pagination for SQLite adapters.

Changes

Cohort / File(s)	Summary
Runtime query interpreter & types `packages/client-engine-runtime/src/interpreter/query-interpreter.ts`, `packages/client-engine-runtime/src/query-plan.ts`	Imported `InMemoryOps` and added runtime evaluation of processing parameters for `process` nodes (calls `evaluateProcessingParameters` for `node.args.operations`). Changed `Pagination.cursor` type from `Record<string, PrismaValue>
Functional tests for composite cursor pagination `packages/client/tests/functional/issues/29176-cursor-parameter-regression/_matrix.ts`, `packages/client/tests/functional/issues/29176-cursor-parameter-regression/prisma/_schema.ts`, `packages/client/tests/functional/issues/29176-cursor-parameter-regression/tests.ts`	Added test matrix, provider-aware Prisma schema defining `ListResult` with composite unique index, and a test that inserts rows and asserts correct results for composite cursor `findMany` (validates cursor-based pagination behavior).

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: handle parameterised values in the cursor' directly describes the main fix addressing cursor parameter handling.
Linked Issues check	✅ Passed	The PR addresses issue `#29176` by implementing cursor parameter evaluation, adding regression test with composite cursor pagination, and restoring correct semantics.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing cursor parameter handling: query interpreter logic, type corrections, and regression tests for composite cursors.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/fix-29176

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-02-13T12:23:03Z

Client memory tests, node 22.12.0, client:
❌ Failure, see report.

coderabbitai

Actionable comments posted: 1

packages/client/tests/functional/issues/29176-cursor-parameter-regression/tests.ts

github-actions · 2026-02-13T12:24:45Z

Client memory tests, node 24, client:
✅ Success

github-actions · 2026-02-13T12:30:34Z

size-limit report 📦

Path	Size
packages/client/runtime/index-browser.js	2.23 KB (0%)
packages/client/runtime/index-browser.d.ts	3.28 KB (0%)
packages/cli/build/index.js	2.53 MB (0%)
packages/client/prisma-client-0.0.0.tgz	26.77 MB (+0.01% 🔺)
packages/cli/prisma-0.0.0.tgz	12.75 MB (0%)
packages/bundle-size/da-workers-libsql/output.tgz	1.32 MB (+0.01% 🔺)
packages/bundle-size/da-workers-neon/output.tgz	1.39 MB (+0.01% 🔺)
packages/bundle-size/da-workers-pg/output.tgz	1.38 MB (+0.01% 🔺)
packages/bundle-size/da-workers-planetscale/output.tgz	1.33 MB (+0.01% 🔺)
packages/bundle-size/da-workers-d1/output.tgz	1.3 MB (+0.01% 🔺)

… not creating a minor release yet. prisma/prisma#29184

[TML-1902](https://linear.app/prisma-company/issue/TML-1902/investigate-and-fix-cursor-pagination-regression-in-74) Fixes #29176  ## Summary by CodeRabbit * **Bug Fixes** * Fixed cursor-based pagination to correctly evaluate dynamic cursor and nested processing parameters during in-memory query processing. * **Tests** * Added functional tests validating composite cursor pagination and related behavior. * **Chores** * Tightened the pagination cursor type for stronger type-safety in client runtime.

fix: handle parameterised values in the cursor

b2e3db1

coderabbitai bot reviewed Feb 13, 2026

View reviewed changes

packages/client/tests/functional/issues/29176-cursor-parameter-regression/tests.ts Outdated Show resolved Hide resolved

aqrln added this to the 7.4.1 milestone Feb 13, 2026

aqrln approved these changes Feb 13, 2026

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2026

chore: correct typo

4b96f40

jacek-prisma merged commit 1701fe6 into main Feb 13, 2026
255 of 256 checks passed

jacek-prisma deleted the fix/fix-29176 branch February 13, 2026 13:23

SupertigerDev added a commit to Nerimity/nerimity-server that referenced this pull request Feb 15, 2026

downgrade from prisma 7.4.0 to 7.3.0 because for some reason they are…

7c2aafb

… not creating a minor release yet. prisma/prisma#29184

jacek-prisma mentioned this pull request Feb 16, 2026

Prisma 7.4 breaks pagination with MariaDB #29201

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: handle parameterised values in the cursor#29184

fix: handle parameterised values in the cursor#29184
jacek-prisma merged 2 commits intomainfrom
fix/fix-29176

jacek-prisma commented Feb 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 13, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jacek-prisma commented Feb 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jacek-prisma commented Feb 13, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 13, 2026 •

edited

Loading

github-actions bot commented Feb 13, 2026 •

edited

Loading

github-actions bot commented Feb 13, 2026 •

edited

Loading

github-actions bot commented Feb 13, 2026 •

edited

Loading