Skip to content

fix(cli): Studio fails PostgreSQL validations on connect when ORM-specific query parameters exist in connection string.#28658

Merged
igalklebanov merged 1 commit intomainfrom
studio-strip-orm-query-params
Nov 24, 2025
Merged

fix(cli): Studio fails PostgreSQL validations on connect when ORM-specific query parameters exist in connection string.#28658
igalklebanov merged 1 commit intomainfrom
studio-strip-orm-query-params

Conversation

@igalklebanov
Copy link
Copy Markdown
Contributor

@igalklebanov igalklebanov commented Nov 22, 2025

Hey 👋

closes PTL-556.
closes prisma/studio#1363.

This PR omits any Prisma ORM-specific query parameters from the connection string before passing it to postgres.js.

Copilot AI review requested due to automatic review settings November 22, 2025 01:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where Prisma Studio fails PostgreSQL connection validation when the connection string contains Prisma ORM-specific query parameters that are not recognized by the postgres.js client. The fix filters out these parameters before establishing the connection.

Key changes:

  • Added a constant list of Prisma ORM-specific query parameters that need to be removed
  • Modified the connection string processing to strip out these parameters before passing to postgres.js

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@igalklebanov igalklebanov added this to the 7.0.1 milestone Nov 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 22, 2025

size-limit report 📦

Path Size
packages/client/runtime/index-browser.js 2.23 KB (0%)
packages/client/runtime/index-browser.d.ts 3.28 KB (0%)
packages/cli/build/index.js 2.51 MB (+0.01% 🔺)
packages/client/prisma-client-0.0.0.tgz 10.22 MB (0%)
packages/cli/prisma-0.0.0.tgz 6.71 MB (+0.01% 🔺)
packages/bundle-size/da-workers-libsql/output.tgz 804.7 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 859.16 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 852.02 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 803.84 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 787.59 KB (0%)

@igalklebanov igalklebanov force-pushed the studio-strip-orm-query-params branch from a5448cb to c69c069 Compare November 24, 2025 08:45
@igalklebanov igalklebanov merged commit 863b915 into main Nov 24, 2025
167 of 168 checks passed
@igalklebanov igalklebanov deleted the studio-strip-orm-query-params branch November 24, 2025 09:11
jkomyno pushed a commit that referenced this pull request Nov 25, 2025
…cific query parameters exist in connection string. (#28658)

Hey 👋

closes prisma/studio#1363.

This PR omits any Prisma ORM-specific query parameters from the
connection string before passing it to postgres.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

STUDIO: unrecognized configuration parameter "schema"

3 participants