fix(client): reference the correct edge.js file#28481
Merged
Conversation
`edge.mjs` doesn't exist, it should be `edge.js` for both `require` and `import`, like index, `default` and `extension` entrypoints do. Well, it technically shouldn't, but let's make it consistent with the normal entrypoint for now, and change all of them later if needed. Follow up to #28480
Contributor
size-limit report 📦
|
jkomyno
approved these changes
Nov 8, 2025
wmadden
approved these changes
Nov 8, 2025
Contributor
wmadden
left a comment
There was a problem hiding this comment.
I can't really validate whether this change is correct or not but structurally it looks fine 🤷🏻
aqrln
added a commit
that referenced
this pull request
Nov 17, 2025
`edge.mjs` doesn't exist, it should be `edge.js` for both `require` and `import`, like index, `default` and `extension` entrypoints do. Well, it technically shouldn't, but let's make it consistent with the normal entrypoint for now, and change all of them later if needed. Follow up to #28480
aqrln
added a commit
that referenced
this pull request
Nov 17, 2025
`edge.mjs` doesn't exist, it should be `edge.js` for both `require` and `import`, like index, `default` and `extension` entrypoints do. Well, it technically shouldn't, but let's make it consistent with the normal entrypoint for now, and change all of them later if needed. Follow up to #28480
aqrln
added a commit
that referenced
this pull request
Nov 17, 2025
`edge.mjs` doesn't exist, it should be `edge.js` for both `require` and `import`, like index, `default` and `extension` entrypoints do. Well, it technically shouldn't, but let's make it consistent with the normal entrypoint for now, and change all of them later if needed. Follow up to #28480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edge.mjsdoesn't exist, it should beedge.jsfor bothrequireandimport, like index,defaultandextensionentrypoints do.Well, it technically shouldn't, but let's make it consistent with the normal entrypoint for now, and change all of them later if needed.
Follow up to #28480