fix(adapter-pg): error event listener leak#28057
Conversation
|
|
jacek-prisma
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution
|
@jacek-prisma How do we use this? The final version is 6.15.0. |
|
Does this actually fix the problem? Just from looking at the code, it seems to me that it just makes it more unlikely, right? Wouldn't the error still appear if there were more concurrent transactions than the respective max listeners setting allows? |
|
@afonsomatos it'll be in the next minor release which will release soon |
|
@jacek-prisma I just quickly tried out v6.16.0-dev.37 and the issue still happening. Is this commit included in there already? |
|
@PatrickRogg It helped for me, the issue is gone. Make sure you updated the |
|
Ah, my bad. The package wasn't updated in my turbo repo. Works now. Thanks for fixing this @Zhincore |
This PR fixes the same event listener leak for `adapter-mariadb` that was resolved in `adapter-pg` (#28057).
This PR fixes the same event listener leak for `adapter-mariadb` that was resolved in `adapter-pg` (#28057).
This PR fixes the same event listener leak for `adapter-mariadb` that was resolved in `adapter-pg` (#28057).
Fixes an issue where when executing enough transactions in quick succession and pg-pool starts to reuse clients, error handlers are re-attached to them but old ones aren't removed, causing the
MaxListenersExceededWarningand supposedly a memory leak.Closes #28037