Conversation
Contributor
size-limit report 📦
|
jkomyno
requested changes
Dec 16, 2024
Contributor
jkomyno
left a comment
There was a problem hiding this comment.
Please go through every client test that contains Json fields in schemas, and ensure that the sqlite provider is tested there.
Start by looking for Json in ./packages/client/tests/functional.
You may need to add { provider: Providers.SQLITE } in places like this, and remove sqlite from the optOut lists (example).
CodSpeed Performance ReportMerging #25871 will degrade performances by 20.07%Comparing Summary
Benchmarks breakdown
|
Contributor
|
🟢 All good, this PR is no longer uses custom engine. |
jkomyno
approved these changes
Dec 18, 2024
aqrln
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix required for prisma/prisma-engines#5088