Conversation
Contributor
size-limit report 📦
|
@prisma/client@prisma/client
Contributor
Author
|
Note: there are currently some ecosystem-tests failures, notably in the |
Contributor
|
ecosytem-tests failure could be a flake, although i haven't seen this one before. Restarted the test for now. |
SevInf
approved these changes
May 28, 2024
Contributor
SevInf
left a comment
There was a problem hiding this comment.
LGTM, but let's figure this ecosystem-tests failure before merging
Jolg42
reviewed
May 29, 2024
Jolg42
approved these changes
May 29, 2024
Contributor
|
Note: the failures look unrelated to this PR because the default branch shows the same failures |
Jolg42
reviewed
May 29, 2024
This was referenced May 30, 2024
Closed
SevInf
pushed a commit
that referenced
this pull request
May 30, 2024
…l Edge in `@prisma/client` (#24312) Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR impacts how the Wasm Query Engine is loaded with
@prisma/client's conditional import maps.In particular, this PR:
@prisma/clientis a CommonJS package - so no top-levelawaitis availablegetQueryEngineWasmModuleresolves the Wasm modules, using a sequence ofawaits to avoid the infamous "TypeError: WebAssembly.Instance(): Argument 0 must be a WebAssembly.Module" errorFor additional context:
/integration
You can try this PR with the integration version:
5.15.0-integration-client-dynamic-wasm-imports.1.