ci(windows): fix MySQL setup by switching to MySQL-LTS#24030
Merged
Conversation
Contributor
size-limit report 📦
|
Jolg42
added a commit
to prisma/prisma-engines
that referenced
this pull request
Apr 30, 2024
8.3.0
8.3.0
Contributor
Author
|
Merging right away to make CI green again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working (MySQL 8.3.0)
https://github.com/prisma/prisma/actions/runs/8891591771/job/24413987446#step:5:26
Failing (MySQL 8.4.0)
https://github.com/prisma/prisma/actions/runs/8893834670/job/24421984166?pr=24020#step:5:26
It's better to test against the LTS version actually:
See https://scoop.sh/#/apps?q=mysql&id=370d4f508846f7104951ab137f0da2abbd19b793
Code copied from https://github.com/prisma/prisma-engines/blob/c559fb9c995935fddcb17395e55d4d863149a3c3/.github/workflows/test-schema-engine.yml#L235-L243