Conversation
🤖 Pull request artifactsempty string
|
janpio
suggested changes
May 27, 2024
Contributor
janpio
left a comment
There was a problem hiding this comment.
As far as I understood, rootpath will not be the correct, usable path for this on Windows.
SevInf
approved these changes
May 28, 2024
SevInf
requested changes
May 28, 2024
SevInf
left a comment
There was a problem hiding this comment.
Would changing rootPath from uri.path to uri.fsPath fix the issue?
Contributor
|
From what I linked to in the Slack discussion, yes. Not sure what potential side effects this would have of course. |
Contributor
Author
|
I can confirm that it works on windows now :) that was harrowing 💀 Screen.Recording.2024-05-29.at.11.20.20.mov |
SevInf
approved these changes
May 29, 2024
Jolg42
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pass cwd directly to exec instead of cd
fixes #1738