rename Primus.require => Primus.requires#432
Merged
Merged
Conversation
4635d0c to
59ac82b
Compare
Member
|
The change seems ok, but I'm a bit worried about plugins. @3rd-Eden thoughts? |
because react-native packager treat every function named require as module loader, loading primus client in react-native throw error that cannot resolve stream model.
59ac82b to
9f04747
Compare
Contributor
Author
|
not sure why anyone would like to use that, but I have update commit to assign Primus.require also, problem is only when you call |
Member
|
👍 Thank you. |
lpinca
added a commit
that referenced
this pull request
Feb 18, 2016
rename Primus.require => Primus.requires
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
react-nativewithprimusgenerated lib will throw errorafter some debugging I have figured out that
react-nativepackager assume that every method with namerequireis normal require method.So replacing the function name with something else instead of
Primus.requirewill fix that problem.