Closed
Conversation
4 tasks
fisker
commented
Dec 10, 2020
| test <World /> test | ||
| </Hello>123 | ||
| </Hello> | ||
| 123 |
paragraph printparagraph print
fb4e2c4 to
232bef1
Compare
# Conflicts: # src/language-markdown/printer-markdown.js
# Conflicts: # src/language-markdown/printer-markdown.js
Member
Author
|
@thorn0 Can you review this, when you got time? This is actually quite big change, because it called unsafe |
Member
|
Ooops, I keep forgetting about this one... |
Member
|
The doc for #9503 still doesn't look right: [
fill([
conditionalGroup([
group([/*...*/]),
group([/*...*/]),
]),
" ", // <--- should be `line`
"is",
line,
// ... |
thorn0
reviewed
Jan 31, 2021
| if (typeof printed === "string") { | ||
| return printed; | ||
| } | ||
| return fill(getDocParts(printed)); |
Member
There was a problem hiding this comment.
Passing the result of cleanDoc to fill is wrong. cleanDoc doesn't guarantee that the array has the expected structure.
Member
Author
There was a problem hiding this comment.
Yes, you are right, and it seems I've done something wrong in other places, I'll check.
Member
|
Yes, this is a big one. My research plan so far: MDX: line break inserted between elements and text in JSX blocks
|
4 tasks
# Conflicts: # src/language-markdown/printer-markdown.js
…markdown-paragraph # Conflicts: # src/language-markdown/printer-markdown.js
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #9503
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨