Add core-js support for build script#6866
Closed
fisker wants to merge 6 commits intoprettier:masterfrom
Closed
Conversation
core-js support for bundlecore-js support for build script
alexander-akait
approved these changes
Nov 7, 2019
This was referenced Nov 9, 2019
Member
|
As far as I understand, we won’t need this in 2.0 so I’m closing. Let me know if I’ve misunderstood anything. |
Member
|
@fisker Feel free to continue discussion here. We’ll reopen if needed. |
Member
Author
|
@lydell You are right, we can reopen it when we need it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we've already drop Node 6 support for direct install from github, we could start using some new Syntax like
async,Array.includesand more, at least forcorebundles.Also, some new version of dependencies requires
asyncandArray#include, but our build script can't handle, likeglobby@10(#6776),cosmiconfig@6(#6850).I add this as an option, and not enable for any bundle yet, also only allow to use for core bundles.
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨