Skip to content

Update cosmiconfig to v6#6850

Merged
thorn0 merged 8 commits intoprettier:nextfrom
fisker:update-cosmiconfig-6
Jan 10, 2020
Merged

Update cosmiconfig to v6#6850
thorn0 merged 8 commits intoprettier:nextfrom
fisker:update-cosmiconfig-6

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Nov 6, 2019

fixes #6810

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker changed the title Bump cosmiconfig from 5.2.1 to 6.0.0 Bump cosmiconfig from 5.2.1 to 6.0.0 Nov 6, 2019
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, one note

@fisker

This comment has been minimized.

@fisker

This comment has been minimized.

@fisker

This comment has been minimized.

@fisker fisker force-pushed the update-cosmiconfig-6 branch from c8446ae to 299359a Compare November 6, 2019 15:16
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 6, 2019

another funny story, bug is from import-fresh , it clean require cache from parent module calc path from parent module, make sense right? because calling require is from parent module no need clean import-fresh self path should related to parent module, but when we bundle this module, there will be no parent, haha. too tired to confirm this.

fisker#151

last two commits might fix this, going to sleep now, 2am...

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 6, 2019

@brodybits

@alexander-akait
Copy link
Copy Markdown
Member

@fisker I can take care of updating if you have problems

@brody2consult
Copy link
Copy Markdown

I just tried yarn prepare-release and got ReferenceError: regeneratorRuntime is not defined on tests_integration/__tests__/config-resolution.js.

I think we should be able to resolve it by using babel-plugin-transform-async-to-promises, just like you did for the globby@10 update in PR #6776. I think we would need to keep this for browser support, even if we drop Node.js pre-8.0 support.

I would not personally favor pushing this update into the upcoming Prettier 1.19 release. Definitely a good job, though.

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 6, 2019

@brodybits i know that, success build bundle also not work

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 6, 2019

@evilebottnawi go for it

@fisker fisker mentioned this pull request Nov 7, 2019
4 tasks
@fisker fisker changed the base branch from master to next November 14, 2019 03:31
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 14, 2019

changed base to next branch

@fisker fisker changed the title Bump cosmiconfig from 5.2.1 to 6.0.0 Update cosmiconfig to v6 Nov 14, 2019
@alexander-akait
Copy link
Copy Markdown
Member

@fisker why next? Here breaking change?

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 14, 2019

@evilebottnawi

Can't make bundle work on node@4

  • async functions need babel-plugin-transform-async-to-promises or regenerate-runtime,
  • util.promisify requires another shim, like pify
  • also need transform includes to indexOf
  • most important, require-fresh not play well on node 4, hard to find a solution

not worth to dig

@alexander-akait
Copy link
Copy Markdown
Member

Okey, let's do it for next

@thorn0 thorn0 added this to the 2.0 milestone Jan 9, 2020
@thorn0 thorn0 force-pushed the update-cosmiconfig-6 branch 2 times, most recently from ffc7014 to 7280b57 Compare January 9, 2020 23:57
@thorn0 thorn0 force-pushed the next branch 3 times, most recently from e16f758 to 7d88fb8 Compare January 10, 2020 00:39
@thorn0 thorn0 force-pushed the update-cosmiconfig-6 branch from 7280b57 to 37a9175 Compare January 10, 2020 00:59
@thorn0 thorn0 merged commit ea23fc5 into prettier:next Jan 10, 2020
@fisker fisker deleted the update-cosmiconfig-6 branch January 10, 2020 23:23
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants