Support TypeScript 3.7 (using a fork of typescript-estree)#6680
Closed
fisker wants to merge 12 commits intoprettier:masterfrom
Closed
Support TypeScript 3.7 (using a fork of typescript-estree)#6680fisker wants to merge 12 commits intoprettier:masterfrom
fisker wants to merge 12 commits intoprettier:masterfrom
Conversation
Member
Author
Member
|
I guess I’m fine with using your fork for now. But if so we should make it the top priority to get 2.0 out after 1.19. A non-ambitious 2.0 where we get rid of all unsupported Node.js versions and remove deprecated stuff and other small breaking changes. |
4 tasks
|
I've added this package as a dev dep with TS 3.7.0-beta but when saving |
Member
|
@damiangreen Try this PR instead. If it's still reproduced, please post a snippet of your code to that PR. |
Member
|
@thorn0 that fixed it thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test code is from #6657 (by Cryrivers), replace
@typescript-eslint/typescript-estreev2.4.0 with my fork version that works for node 4assertskeyword (Fixes [TypeScript 3.7] add support forassertskeyword #6574)I suggest we use my fork until prettier starting v2.0.0(will drop node 6 support #3919), since many people want Typescript 3.7 support. we can switch back anytime
Yesterday, I saw someone from
typescript-eslintteam says they may try to bring node 6 support back, hope it's true.My build script can be found on https://github.com/fisker/typescript-estree-for-node-6 , repo is a little mess now
docs/directory)CHANGELOG.unreleased.mdfile following the template.✨Try the playground for this PR✨