Skip to content

Support TypeScript 3.7 (using a fork of typescript-estree)#6680

Closed
fisker wants to merge 12 commits intoprettier:masterfrom
fisker:typescript-37-attempt-2
Closed

Support TypeScript 3.7 (using a fork of typescript-estree)#6680
fisker wants to merge 12 commits intoprettier:masterfrom
fisker:typescript-37-attempt-2

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Oct 17, 2019

Test code is from #6657 (by Cryrivers), replace @typescript-eslint/typescript-estree v2.4.0 with my fork version that works for node 4

I suggest we use my fork until prettier starting v2.0.0(will drop node 6 support #3919), since many people want Typescript 3.7 support. we can switch back anytime

Yesterday, I saw someone from typescript-eslint team says they may try to bring node 6 support back, hope it's true.

My build script can be found on https://github.com/fisker/typescript-estree-for-node-6 , repo is a little mess now

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review October 17, 2019 20:10
@lydell
Copy link
Copy Markdown
Member

lydell commented Oct 17, 2019

I guess I’m fine with using your fork for now. But if so we should make it the top priority to get 2.0 out after 1.19. A non-ambitious 2.0 where we get rid of all unsupported Node.js versions and remove deprecated stuff and other small breaking changes.

@thorn0 thorn0 changed the title Support TypeScript 3.7 Support TypeScript 3.7 (using a fork of typescript-estree) Oct 22, 2019
@damiangreen
Copy link
Copy Markdown

damiangreen commented Oct 24, 2019

I've added this package as a dev dep with TS 3.7.0-beta but when saving ?. gets replaced with .

@thorn0
Copy link
Copy Markdown
Member

thorn0 commented Oct 25, 2019

@damiangreen Try this PR instead. If it's still reproduced, please post a snippet of your code to that PR.

@thorn0
Copy link
Copy Markdown
Member

thorn0 commented Oct 25, 2019

As we're moving forward with #6657, it's time to close this PR.

Thank you for your work and research @fisker!

@thorn0 thorn0 closed this Oct 25, 2019
@damiangreen
Copy link
Copy Markdown

@thorn0 that fixed it thanks!

@prettier prettier locked as resolved and limited conversation to collaborators Oct 25, 2019
@fisker fisker deleted the typescript-37-attempt-2 branch June 12, 2020 05:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

4 participants