@fisker it is better to avoid PRs for 2 branch now, since we didn’t even start it, better fix bugs

@evilebottnawi How about the idea of using a fork version of @typescript-eslint/typescript-estree that supports old node version, if this is OK, i will try to improve the fork

Personally, considering the maintenance cost of the fork, it is better to hurry for major updates for us.

@fisker it is problem not only for typescript, other packages also can require node@8, I think we should talk about it and choose the best strategy.

? is still lost if the key is an expression. The AST doesn't even contain the relevant info.

Prettier pr-6601
Playground link

--parser typescript

Input:

class Foo {
    [Symbol.bar]?();
}

Output:

class Foo {
  [Symbol.bar]();
}

@fisker, probably, my issue is connected with the one you are fixing in this PR. Could you also take a look at it? I tried it in the PR playground but the issue is still reproducible.

• PR Playground

@thorn0 I think this problem caused by parser side.

@Lodin I think your issue is not related to this PR. Probably, it is other problem, so we can fix your issue without updating typescript-estree.

#6673 fixes @Lodin 's issue, but only for simple cases where the key is a simple identifier (variable). Cases where the key is a more complex expression indeed require an update of typescript-estree to be fixed.