Skip to content

chore: update typescript-estree to new package name#5799

Merged
JamesHenry merged 2 commits intomasterfrom
typescript-estree-package-name
Jan 29, 2019
Merged

chore: update typescript-estree to new package name#5799
JamesHenry merged 2 commits intomasterfrom
typescript-estree-package-name

Conversation

@JamesHenry
Copy link
Copy Markdown
Collaborator

@JamesHenry JamesHenry commented Jan 25, 2019

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@JamesHenry
Copy link
Copy Markdown
Collaborator Author

JamesHenry commented Jan 25, 2019

I will mark the original npm package as deprecated for clarity once this goes in

@JamesHenry
Copy link
Copy Markdown
Collaborator Author

JamesHenry commented Jan 25, 2019 •
edited
Loading

Importantly - typescript-estree will very much continue to be an agnostic TypeScript -> ESTree AST tool.

Prettier's use case is just as important to me as ESLint's.

It's movement into the typescript-eslint monorepo is purely to help with the maintenance burden and coordinating releases across the ecosystem.

@JamesHenry
Copy link
Copy Markdown
Collaborator Author

JamesHenry commented Jan 25, 2019

If anybody else from the Prettier Team wants to be directly involved on the monorepo please just let me know

@existentialism
Copy link
Copy Markdown
Collaborator

existentialism commented Jan 25, 2019

@JamesHenry happy to help!

j-f1
j-f1 requested changes Jan 25, 2019
View reviewed changes
duailibe
duailibe approved these changes Jan 28, 2019 •
edited
Loading
View reviewed changes
@JamesHenry
Copy link
Copy Markdown
Collaborator Author

JamesHenry commented Jan 29, 2019

@existentialism Thanks! Added you to https://github.com/orgs/typescript-eslint/teams/prettier-team

@JamesHenry JamesHenry merged commit 1143619 into master Jan 29, 2019
@JamesHenry JamesHenry deleted the typescript-estree-package-name branch January 29, 2019 00:46
@ikatyang ikatyang mentioned this pull request Jan 30, 2019
Closed
@ikatyang ikatyang added this to the 1.16.2 milestone Jan 30, 2019
ikatyang added a commit to ikatyang/prettier that referenced this pull request Jan 31, 2019
@ikatyang
Revert "chore: update typescript-estree to new package name (prettier…
ffaf39b 
…#5799)"

This reverts commit 1143619.
ikatyang added a commit that referenced this pull request Jan 31, 2019
@ikatyang
Revert "chore: update typescript-estree to new package name (#5799)" (#…
fc93bbc 
…5818)
@ikatyang ikatyang mentioned this pull request Feb 2, 2019
Closed
3 tasks
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@duailibe duailibe duailibe approved these changes

@j-f1 j-f1 j-f1 requested changes

@existentialism existentialism existentialism approved these changes

@ikatyang ikatyang ikatyang approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.16.2

Development

Successfully merging this pull request may close these issues.

5 participants

@JamesHenry @existentialism @duailibe @ikatyang @j-f1