Skip to content

docs(blog): 1.14 release#4857

Merged
ikatyang merged 40 commits intoprettier:masterfrom
ikatyang:docs/blog-1.14
Jul 29, 2018
Merged

docs(blog): 1.14 release#4857
ikatyang merged 40 commits intoprettier:masterfrom
ikatyang:docs/blog-1.14

Conversation

@ikatyang
Copy link
Copy Markdown
Member

@ikatyang ikatyang commented Jul 17, 2018

1.14 release tracked in #4856.

Not sure which item should be highlighted, feel free to edit this PR directly.

View the rendered blog post here

@ikatyang ikatyang mentioned this pull request Jul 17, 2018
@ikatyang ikatyang added this to the 1.14 milestone Jul 17, 2018
@ikatyang ikatyang added the status:wip Pull requests that are a work in progress and should not be merged label Jul 17, 2018
Putting long values on new rows is the core feature of Prettier,
but we found that it won't improve readability for string value in object,
the long values being put onto new rows would still not fit the print width in most of the time.
In Prettier 1.14, string values in object won't be extended to the next line no matter it fits the print width or not.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t this just JSON{,5}?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. I originally thought it's in the JSON section so I didn't mention it.


#### Handle JSX whitespace separately from fbt whitespace ([#4717] by [@karl])

TODO
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone help me with this item? I don't have too many context on it, not sure how to describe it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I copied some sentences from the original PR to describe it, hope it should be fine.

@ikatyang
Copy link
Copy Markdown
Member Author

The blog post is almost done (1 TODO item except the post date one), should be ready for review.

@ikatyang ikatyang removed the status:wip Pull requests that are a work in progress and should not be merged label Jul 22, 2018
@ikatyang ikatyang changed the title docs(blog): 1.14 release draft docs(blog): 1.14 release Jul 22, 2018
@ikatyang
Copy link
Copy Markdown
Member Author

Finished all items, ready for review.

@ikatyang
Copy link
Copy Markdown
Member Author

Since there's no one comment here so I guess this blog post is fine. I'll merge #4893 tomorrow and release 1.14 if there's no further comment.

Thanks @j-f1 and @existentialism for tweaking my wording.

@duailibe
Copy link
Copy Markdown
Collaborator

Sorry @ikatyang I haven't been able to review this and can't in the next few days, but I support you releasing it :-)

@j-f1

This comment has been minimized.

j-f1 and others added 2 commits July 26, 2018 17:25
Also translate some text to English & convert “'” to “’”.
<!-- Output (Prettier 1.13) -->
<mailto:hello@example.com>

<!-- Output (Prettier 1.13) -->
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.14?

ikatyang and others added 3 commits July 28, 2018 14:05
Prettier doesn’t convert your CSS to Markdown (… yet!)
@ikatyang ikatyang merged commit c2d90f1 into prettier:master Jul 29, 2018
@ikatyang ikatyang deleted the docs/blog-1.14 branch July 29, 2018 07:25
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Oct 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants