Skip to content

Blacklist this in functional composition heuristics#4836

Merged
duailibe merged 1 commit intoprettier:masterfrom
princed:functional_composition_this
Jul 12, 2018
Merged

Blacklist this in functional composition heuristics#4836
duailibe merged 1 commit intoprettier:masterfrom
princed:functional_composition_this

Conversation

@princed
Copy link
Copy Markdown
Contributor

@princed princed commented Jul 12, 2018

As filtering out this and super cases in #4758 didn't seem to get any objections, here's that part as a separate PR:

Do not react when MemberExpression object type is ThisExpression or Super
Filters out cases like

this.compose(a(), b);
super.compose(a(), b);

cc @suchipi

@princed princed mentioned this pull request Jul 12, 2018
Closed
@duailibe duailibe merged commit 03ee86e into prettier:master Jul 12, 2018
@suchipi
Copy link
Copy Markdown
Member

suchipi commented Jul 12, 2018

Thanks @princed!

@princed
Copy link
Copy Markdown
Contributor Author

princed commented Jul 13, 2018

Thank you for merging! When is the next release planned?

@princed princed deleted the functional_composition_this branch July 13, 2018 02:08
@ikatyang ikatyang added this to the 1.14 milestone Jul 17, 2018
@lydell
Copy link
Copy Markdown
Member

lydell commented Jul 21, 2018

@princed #1722

@princed
Copy link
Copy Markdown
Contributor Author

princed commented Jul 21, 2018

@lydell Thanks! Looks like it's rather #4856

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Oct 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@duailibe duailibe duailibe approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

1.14

Development

Successfully merging this pull request may close these issues.

6 participants

@princed @suchipi @lydell @duailibe @j-f1 @ikatyang