Merged
Conversation
We used to be very naive and just push all the comments at the top of the class, but it's very brute force (and breaks some flow annotations inside of fb) so we can do better :)
vjeux
added a commit
to vjeux/prettier
that referenced
this pull request
Aug 24, 2017
I wrote this fix a while ago but it conflicted with the class heuristic, now that prettier#2660 fixes it, we can ship this one as well! Fixes prettier#1460 Fixes prettier#2507
vjeux
added a commit
to vjeux/prettier
that referenced
this pull request
Aug 24, 2017
I wrote this fix a while ago but it conflicted with the class heuristic, now that prettier#2660 fixes it, we can ship this one as well! Fixes prettier#1460 Fixes prettier#2507
vjeux
added a commit
that referenced
this pull request
Aug 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to be very naive and just push all the comments at the top of the class, but it's very brute force (and breaks some flow annotations inside of fb) so we can do better :)