Skip to content

Upgrade to latest micromark (markdown only)#18277

Merged
fisker merged 128 commits into
mainfrom
remark-11-markdown
Dec 26, 2025
Merged

Upgrade to latest micromark (markdown only)#18277
fisker merged 128 commits into
mainfrom
remark-11-markdown

Conversation

@fisker

@fisker fisker commented Nov 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Playground

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

j-f1 and others added 30 commits February 17, 2023 10:05
@j-f1 @fisker
Replace front matter plugin with just calling parseFrontMatter first
a3c5077
@j-f1 @fisker
Bump remark
660bab4
@j-f1 @fisker
Rewrite liquid plugin
c2e0b48
@j-f1 @fisker
Update format-test.js
bca0429
@j-f1 @fisker
Rewrite wikiLink
2605764
@j-f1 @fisker
Allow newlines in liquid*
2c82682 
*only 1 tho
@j-f1 @fisker
Use node.raw instead of originalText when printing front-matter
d44c5f5
@j-f1 @fisker
Don’t throw in wikiLink (not sure why)
7dc0d44
@j-f1 @fisker
Fix multiline liquid expressions
73f6a22
@j-f1 @fisker
Fix wiki link parsing
506e4d0
@j-f1 @fisker
Differentiate between inline/block liquid
ab1f05d
@fisker
Fix build script
f8c4ddb
@fisker
Fix build script
a6c7404
@j-f1 @fisker
+ remark-gfm
87d1cd5
@j-f1 @fisker
Remove GFM autolink support + duplicate footnotes extension
53bb714
@j-f1 @fisker
Enable development condition in tests
49f2285
@j-f1 @fisker
Remove unsued vars
76e5701
@j-f1 @fisker
Remove flow wiki link construct
2ac3841
@j-f1 @fisker
update snapshots
22e8011
@fisker
Update snapshot
c070d82
@fisker
Bring old mdx parser back
7d4dc4c
@fisker
Fix
68d16b0
@fisker
Fix snapshots
93479bf
@fisker
Markdown: Remove loos-item plugin
eea6276
@fisker
Use charAt insteadOf slice
bcfe843
@fisker
Fix html
7e0b37d
@fisker
fix
35628ac
@fisker
Revert "Fix html"
01aa8aa 
This reverts commit 44b0283.
@fisker
Bad merge
936ea90
@fisker
upgrade unified
95967b3
fisker
fisker commented Dec 26, 2025
View reviewed changes
Comment thread tests/format/markdown/commonmark-test-suite/__snapshots__/format.test.js.snap
* * *

=====================================output=====================================
---

@fisker fisker Dec 26, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can potentially change the <hr> to front matter. But I think it's fine to let it go.

Prettier pr-18277
Playground link

--parser markdown

Input:

* * *
something: not-front-matter
---

Output:

---

something: not-front-matter
---

Second Output:

---
something: not-front-matter
---

@fisker

fisker commented Dec 26, 2025

Copy link
Copy Markdown
Member Author

@seiyab

I plan to merge this PR and continue work on the MDX upgrade. Do you have any work left that you want to finish before I merge?

Are you fine with squashing all these changes into one commit?

@fisker fisker marked this pull request as ready for review December 26, 2025 08:21
@seiyab

seiyab commented Dec 26, 2025

Copy link
Copy Markdown
Collaborator

Do you have any work left that you want to finish before I merge?

I wonder if we need to see loose list item in block quote (seen in MDN integration test).
In my opinion, trivial ones, that won't block release, will be able to be worked on the main branch after this will be merged. I'm neutral for the loose list item diff.

Are you fine with squashing all these changes into one commit?

Yes 😁

@fisker fisker merged commit 6c339cd into main Dec 26, 2025
43 checks passed
@fisker fisker deleted the remark-11-markdown branch December 26, 2025 11:43
@karlhorky

karlhorky commented Dec 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@fisker @seiyab congratulations getting a PR merged in the direction of getting new MDX versions supported! 🙌 🎉

Looking forward to this landing in a Prettier version!

cc @wooorm @ChristianMurphy @remcohaszing in case you weren't following along already

fisker added a commit to prettier/prettier-plugin-mdx1 that referenced this pull request Jan 4, 2026
@fisker
Extract code and tests from Prettier
b1c0fa6 
Prettier commit hash is 4f1c4d9eb85fe6afb925cc0d57de7f28e786cabe, before prettier/prettier#18277
@tats-u tats-u mentioned this pull request Jan 10, 2026
Open
@tats-u tats-u mentioned this pull request Jan 17, 2026
Closed
@tats-u tats-u mentioned this pull request Feb 15, 2026
Closed
@tats-u tats-u mentioned this pull request Mar 25, 2026
Draft
4 tasks
@seiyab seiyab mentioned this pull request Mar 26, 2026
Merged
4 tasks
This was referenced Apr 9, 2026
Closed
Closed
@tats-u tats-u mentioned this pull request Apr 26, 2026
Closed
This was referenced May 24, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@seiyab seiyab mentioned this pull request Jun 10, 2026
Merged
6 tasks
@tats-u tats-u mentioned this pull request Jun 11, 2026
Closed
@chalin chalin mentioned this pull request Jun 28, 2026
Closed
@YDX-2147483647 YDX-2147483647 mentioned this pull request Jul 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@scutuatua-crypto scutuatua-crypto scutuatua-crypto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fisker @seiyab @tats-u @karlhorky @scutuatua-crypto @j-f1