Skip to content

Fix getFileInfo #18081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisker merged 2 commits into from
Oct 15, 2025
Merged

Fix getFileInfo #18081

fisker merged 2 commits into from
Oct 15, 2025

Conversation

@fisker
Copy link
Member

@fisker fisker commented Oct 15, 2025

Description

When reviewing #17808, I realized that I made the same mistake as #17808 (comment) in #17548

Should use withPlugins instead of load plugins in the API.

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 15, 2025

Open in StackBlitz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/plugin-hermes@18081.tgz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/plugin-oxc@18081.tgz

yarn add https://pkg.pr.new/prettier/prettier@18081.tgz

commit: b545091

@netlify
Copy link

netlify bot commented Oct 15, 2025

✅ Deploy Preview for prettier ready!

Name Link
🔨 Latest commit b545091
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/68f015bd9b8f03000853b738
😎 Deploy Preview https://deploy-preview-18081--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fisker fisker marked this pull request as ready for review October 15, 2025 21:49
@fisker fisker merged commit 3476a69 into prettier:main Oct 15, 2025
33 checks passed
@fisker fisker deleted the getFileInfo branch October 15, 2025 21:50
@fisker fisker mentioned this pull request Nov 29, 2025
Closed
fisker added a commit that referenced this pull request Nov 29, 2025
@fisker
Revert "Fix getFileInfo (#18081)"
e3feb3e 
This reverts commit 3476a69.
@fisker fisker mentioned this pull request Nov 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fisker