Avoid adding colon for track in 3rd expression of for blocks#15887
Merged
sosukesuzuki merged 4 commits intoprettier:mainfrom Jan 8, 2024
Merged
Avoid adding colon for track in 3rd expression of for blocks#15887sosukesuzuki merged 4 commits intoprettier:mainfrom
track in 3rd expression of for blocks#15887sosukesuzuki merged 4 commits intoprettier:mainfrom
Conversation
fisker
reviewed
Jan 7, 2024
| </div> | ||
|
|
||
| <div> | ||
| @for (item of items; let i = $index; track block) {} |
Member
There was a problem hiding this comment.
I don't know much about angular syntax, but we format @for and *ngFor exactly the same, so please add <div *ngFor="item of items; let i = $index; track block"></div> just like the <div> above. We can compare them if we change in future.
fisker
approved these changes
Jan 8, 2024
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 17, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15784
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨