Fix printing comment for the last operand of union types#15409
Merged
sosukesuzuki merged 3 commits intoprettier:mainfrom Sep 16, 2023
Merged
Fix printing comment for the last operand of union types#15409sosukesuzuki merged 3 commits intoprettier:mainfrom
sosukesuzuki merged 3 commits intoprettier:mainfrom
Conversation
added 2 commits
September 16, 2023 18:46
fisker
reviewed
Sep 16, 2023
| if ( | ||
| precedingNode && | ||
| (precedingNode.type === "TSUnionType" || | ||
| precedingNode.type === "UnionTypeAnnotation") && |
Member
There was a problem hiding this comment.
I don't think tests are using flow parsers. Please add more parsers in the tests.
fisker
approved these changes
Sep 16, 2023
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 16, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11910
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨