fix: JSON modules disable named exports#13031
Merged
fisker merged 1 commit intoprettier:mainfrom Jun 21, 2022
Merged
Conversation
Member
|
Will it unblock babel PR if we test those in https://github.com/prettier/prettier/tree/main/tests/format/misc/errors? |
Contributor
Author
|
@fisker Yes that could work, though eventually we have to revise the affected test cases. If you insist I can simply rename the test cases. |
Member
|
Not important. |
4 tasks
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the import-assertions js formatter test, as the JSON modules spec disallows named exports. For example,
export { foo2 } from "./foo.json" assert { type: "json" }is invalid.Currently blocking babel/babel#14668. Babel plans to throw named JSON module imports/exports in the future, hence I update the test so the Babel update won't break our tests.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨