fix: bump synckit for yarn PnP ESM issue#776
Conversation
🦋 Changeset detectedLatest commit: 3cd0048 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughUpdates dependency Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 3317a9d in 22 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:67
- Draft comment:
Bump synckit to ^0.11.12 per upstream patch for yarn PnP issues. Confirm tests cover this change. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_LtuW2pHcgW21ldm6
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Line 67: Update the package.json dependency "synckit" to the patched version
^0.11.12 to address CVE-2025-54313 and Yarn PnP ESM handling; after changing the
dependency, run your package manager install and test to ensure no breakages. If
your repo uses Yarn PnP and you encounter ESM issues, enable the experimental
ESM loader by adding pnpEnableEsmLoader: true in your .yarnrc.yml, then
reinstall and re-run CI; finally, re-run a security audit (e.g., npm audit or
yarn audit) to confirm the vulnerability is resolved.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Synckit was unable to properly load es modules, and would instead hang when eslint attempted to generate diagnostics. A patch was recently introduced upstream [1] so we update to bring in the fix. [1]: un-ts/synckit@4fb10bd Issue: 775
3317a9d to
0a54bec
Compare
commit: |
There was a problem hiding this comment.
Pull request overview
This PR updates the synckit dependency from ^0.11.7 to ^0.11.12 to resolve an issue where ESLint diagnostics would hang when using Yarn Plug'n'Play (PnP) with ES modules. The fix brings in an upstream patch that properly handles ES module loading.
Changes:
- Update
synckitdependency version to include upstream fix for Yarn PnP ESM loading - Add changeset documenting the patch release
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates synckit dependency from ^0.11.7 to ^0.11.12 |
| pnpm-lock.yaml | Updates lock file with new synckit version and its transitive dependency @pkgr/core |
| .changeset/cool-taxes-grin.md | Documents the patch release with description of the fix |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.5.4 | 5.5.5 | ## [v5.5.5](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) ##### Patch Changes - [#772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.5.4 | 5.5.5 | ## [v5.5.5](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) ##### Patch Changes - [#772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.5.4 | 5.5.5 | ## [v5.5.5](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) ##### Patch Changes - [#772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue
This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | devDependencies | patch | [`24.10.7` → `24.10.9`](https://renovatebot.com/diffs/npm/@types%2fnode/24.10.7/24.10.9) | [](https://securityscorecards.dev/viewer/?uri=github.com/DefinitelyTyped/DefinitelyTyped) | | [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | devDependencies | patch | [`5.5.4` → `5.5.5`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/5.5.4/5.5.5) | [](https://securityscorecards.dev/viewer/?uri=github.com/prettier/eslint-plugin-prettier) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier (eslint-plugin-prettier)</summary> ### [`v5.5.5`](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) [Compare Source](prettier/eslint-plugin-prettier@v5.5.4...v5.5.5) ##### Patch Changes - [#​772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@​BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#​776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@​aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44NC4yIiwidXBkYXRlZEluVmVyIjoiNDIuODQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!252 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>
chore(deps): update frontend dependencies (patch) (patch) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | devDependencies | patch | [`24.10.7` → `24.10.9`](https://renovatebot.com/diffs/npm/@types%2fnode/24.10.7/24.10.9) | [](https://securityscorecards.dev/viewer/?uri=github.com/DefinitelyTyped/DefinitelyTyped) | | [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) | devDependencies | patch | [`5.5.4` → `5.5.5`](https://renovatebot.com/diffs/npm/eslint-plugin-prettier/5.5.4/5.5.5) | [](https://securityscorecards.dev/viewer/?uri=github.com/prettier/eslint-plugin-prettier) | --- ### Release Notes <details> <summary>prettier/eslint-plugin-prettier (eslint-plugin-prettier)</summary> ### [`v5.5.5`](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) [Compare Source](prettier/eslint-plugin-prettier@v5.5.4...v5.5.5) ##### Patch Changes - [#​772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@​BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#​776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@​aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44NC4yIiwidXBkYXRlZEluVmVyIjoiNDIuODQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!252 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.5.4 | 5.5.5 | ## [v5.5.5](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) ##### Patch Changes - [#772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.5.4 | 5.5.5 | ## [v5.5.5](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) ##### Patch Changes - [#772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue
| datasource | package | from | to | | ---------- | ---------------------- | ----- | ----- | | npm | eslint-plugin-prettier | 5.5.4 | 5.5.5 | ## [v5.5.5](https://github.com/prettier/eslint-plugin-prettier/blob/HEAD/CHANGELOG.md#555) ##### Patch Changes - [#772](prettier/eslint-plugin-prettier#772) [`7264ed0`](prettier/eslint-plugin-prettier@7264ed0) Thanks [@BPScott](https://github.com/BPScott)! - Bump prettier-linter-helpers dependency to v1.0.1 - [#776](prettier/eslint-plugin-prettier#776) [`77651a3`](prettier/eslint-plugin-prettier@77651a3) Thanks [@aswils](https://github.com/aswils)! - fix: bump synckit for yarn PnP ESM issue
Synckit was unable to properly load es modules, and would instead hang when eslint attempted to generate diagnostics. A patch was recently introduced upstream 1 so we update to bring in the fix.
fix #775
Important
Update
synckitto^0.11.12inpackage.jsonto fix ESLint diagnostics hanging issue with Yarn PnP.synckitversion from^0.11.7to^0.11.12inpackage.jsonto fix ES module loading issue causing ESLint to hang.This description was created by
for 3317a9d. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.