Build out more Benchmark framework + porting over existing benchmarks#73
Merged
Conversation
erichwang
commented
Oct 6, 2012
Contributor
- Abstracted TupleStreamBenchmark framework + converted benchmarks
- Add default serdes to TupleStreamSerdes
- Add StatsCollectingTupleStreamSerde
- Added SelfIdTupleStreamSerde + some other fixes
- Improve BlockBuilder resizing behavior
Summary: The most common pattern for BlockBuilder is to specify a max size, and then keep appending until it reports full before doing something with it. This is inherently inefficient because every time the underlying ByteArraySlice hits the full mark, it will resize and do a full copy of its contents. This means that that for most of the current use cases, we are double copying the data in the BlockBuilder. We can minimize this effect by using a slightly larger underlying storage size.
- fix some bugs in SliceInput - Improve encoding enum - Rename encodings - Refactor Serde to have serializer and deserializer interfaces - Add SelfIdTupleStreamSerde
- Collects stats when serializing, which become available whe deserializing
Summary: Inline operators are operators that process tuples value by value without using a splitter (which requires materialization). They can be inserted inline into a tuplestream with an InlinedOperatorHook. Wrapping an inlined operator with FullInlinedOperatorTupleStream or PartialInlinedOperatorTupleStream gives the view of it as a tuplestream that produces some values. In the stats case, we can produce partial results by querying the results before the full stream has been processed.
Contributor
Author
|
Any other comments on this? |
Contributor
|
looks good |
Summary: - Class renames - Removed the ability to read out the results of an InlinedOperator/TupleValueSink in a generic format. We can figure out how we want to expose this information at a later time.
wraymo
pushed a commit
to wraymo/presto
that referenced
this pull request
Oct 6, 2025
… for CLP's `FormattedFloat` and `DictionaryFloat` types. (prestodb#73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.