Skip to content

fix(plugin-druid): Add version for at.yawk.lz4:lz4-java to fix maven publishing#27571

Merged
unidevel merged 1 commit into
prestodb:release-0.297from
unidevel:297-fix
Apr 13, 2026
Merged

fix(plugin-druid): Add version for at.yawk.lz4:lz4-java to fix maven publishing#27571
unidevel merged 1 commit into
prestodb:release-0.297from
unidevel:297-fix

Conversation

@unidevel

Copy link
Copy Markdown
Contributor

Description

Got error when validating maven artifacts

[INFO] Waiting until Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 is validated
Error:  

Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 failed
pkg:maven/com.facebook.presto/presto-druid@0.297:
 - Dependency management dependency version information is missing for dependency: at.yawk.lz4:lz4-java

Motivation and Context

Impact

Release 0.297

Test Plan

Re-publish

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Apr 13, 2026
@unidevel unidevel marked this pull request as ready for review April 13, 2026 15:33
@unidevel unidevel requested a review from a team as a code owner April 13, 2026 15:33
@prestodb-ci prestodb-ci requested review from a team, Mariamalmesfer and pratyakshsharma and removed request for a team April 13, 2026 15:33
@unidevel

Copy link
Copy Markdown
Contributor Author

Will add a new PR for master branch after published.

@hantangwangd

Copy link
Copy Markdown
Member

Curiously, the version has been defined in the dependencyManagement of the project root pom.xml, and can be built successfully locally.

@hantangwangd hantangwangd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think it's OK to make this change in the current release branch for now.

@unidevel

Copy link
Copy Markdown
Contributor Author

Curiously, the version has been defined in the dependencyManagement of the project root pom.xml, and can be built successfully locally.

This one also defined in the dependencyManagement section of presto-druid/pom.xml‎, probably we can move it out, so that it can use the version from parent pom.xml

@unidevel

Copy link
Copy Markdown
Contributor Author

This version seems moved to root pom.xml to fix some CVE with commit 0528912

@hantangwangd

Copy link
Copy Markdown
Member

This one also defined in the dependencyManagement section of presto-druid/pom.xml‎, probably we can move it out, so that it can use the version from parent pom.xml

Oh, I believe you're correct. The earlier modification may have overlooked the fact that in the presto-druid pom.xml, lz4-java is within dependencyManagement.

@unidevel

Copy link
Copy Markdown
Contributor Author

@hantangwangd for this release, I suggest to add the version back as in this PR to minimize the risk. For master branch, we can move this lz4-java plugin out of the dependencyManagement section of presto-druid/pom.xml‎ so that we have time to fix in case it causes regression.

@unidevel unidevel merged commit 6c8e90a into prestodb:release-0.297 Apr 13, 2026
148 of 151 checks passed
@hantangwangd

Copy link
Copy Markdown
Member

@unidevel, good idea, agree with you.

unidevel added a commit that referenced this pull request Apr 14, 2026
…27584)

## Description

This is [a fix PR](#27571) from
branch release-0.297

## Motivation and Context
Fix maven deployment error, follow the same pattern in
[presto-pinot-toolkit/pom.xml](https://github.com/prestodb/presto/blob/master/presto-pinot-toolkit/pom.xml#L118)

```log
[INFO] Waiting until Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 is validated
Error:  

Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 failed
pkg:maven/com.facebook.presto/presto-druid@0.297:
 - Dependency management dependency version information is missing for dependency: at.yawk.lz4:lz4-java
```

## Impact
Maven deployment

## Test Plan
<!---Please fill in how you tested your change-->

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== NO RELEASE NOTE ==
```
Copilot AI pushed a commit to Joe-Abraham/presto that referenced this pull request Apr 23, 2026
…restodb#27584)

## Description

This is [a fix PR](prestodb#27571) from
branch release-0.297

## Motivation and Context
Fix maven deployment error, follow the same pattern in
[presto-pinot-toolkit/pom.xml](https://github.com/prestodb/presto/blob/master/presto-pinot-toolkit/pom.xml#L118)

```log
[INFO] Waiting until Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 is validated
Error:  

Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 failed
pkg:maven/com.facebook.presto/presto-druid@0.297:
 - Dependency management dependency version information is missing for dependency: at.yawk.lz4:lz4-java
```

## Impact
Maven deployment

## Test Plan
<!---Please fill in how you tested your change-->

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== NO RELEASE NOTE ==
```
Co-authored-by: Joe-Abraham <53977252+Joe-Abraham@users.noreply.github.com>
msmygit pushed a commit to msmygit/presto that referenced this pull request Jun 3, 2026
…restodb#27584)

## Description

This is [a fix PR](prestodb#27571) from
branch release-0.297

## Motivation and Context
Fix maven deployment error, follow the same pattern in
[presto-pinot-toolkit/pom.xml](https://github.com/prestodb/presto/blob/master/presto-pinot-toolkit/pom.xml#L118)

```log
[INFO] Waiting until Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 is validated
Error:  

Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 failed
pkg:maven/com.facebook.presto/presto-druid@0.297:
 - Dependency management dependency version information is missing for dependency: at.yawk.lz4:lz4-java
```

## Impact
Maven deployment

## Test Plan
<!---Please fill in how you tested your change-->

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== NO RELEASE NOTE ==
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants