fix(plugin-druid): Add version for at.yawk.lz4:lz4-java to fix maven publishing#27571
Conversation
… to fix Maven Central deployment
|
Will add a new PR for master branch after published. |
|
Curiously, the version has been defined in the |
hantangwangd
left a comment
There was a problem hiding this comment.
But I think it's OK to make this change in the current release branch for now.
This one also defined in the |
|
This version seems moved to root pom.xml to fix some CVE with commit 0528912 |
Oh, I believe you're correct. The earlier modification may have overlooked the fact that in the presto-druid |
|
@hantangwangd for this release, I suggest to add the version back as in this PR to minimize the risk. For master branch, we can move this |
|
@unidevel, good idea, agree with you. |
…27584) ## Description This is [a fix PR](#27571) from branch release-0.297 ## Motivation and Context Fix maven deployment error, follow the same pattern in [presto-pinot-toolkit/pom.xml](https://github.com/prestodb/presto/blob/master/presto-pinot-toolkit/pom.xml#L118) ```log [INFO] Waiting until Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 is validated Error: Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 failed pkg:maven/com.facebook.presto/presto-druid@0.297: - Dependency management dependency version information is missing for dependency: at.yawk.lz4:lz4-java ``` ## Impact Maven deployment ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
…restodb#27584) ## Description This is [a fix PR](prestodb#27571) from branch release-0.297 ## Motivation and Context Fix maven deployment error, follow the same pattern in [presto-pinot-toolkit/pom.xml](https://github.com/prestodb/presto/blob/master/presto-pinot-toolkit/pom.xml#L118) ```log [INFO] Waiting until Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 is validated Error: Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 failed pkg:maven/com.facebook.presto/presto-druid@0.297: - Dependency management dependency version information is missing for dependency: at.yawk.lz4:lz4-java ``` ## Impact Maven deployment ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ``` Co-authored-by: Joe-Abraham <53977252+Joe-Abraham@users.noreply.github.com>
…restodb#27584) ## Description This is [a fix PR](prestodb#27571) from branch release-0.297 ## Motivation and Context Fix maven deployment error, follow the same pattern in [presto-pinot-toolkit/pom.xml](https://github.com/prestodb/presto/blob/master/presto-pinot-toolkit/pom.xml#L118) ```log [INFO] Waiting until Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 is validated Error: Deployment 187b74fc-1b32-40a7-b88a-7ff972813e55 failed pkg:maven/com.facebook.presto/presto-druid@0.297: - Dependency management dependency version information is missing for dependency: at.yawk.lz4:lz4-java ``` ## Impact Maven deployment ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
Description
Got error when validating maven artifacts
Motivation and Context
Impact
Release 0.297
Test Plan
Re-publish
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.