[presto][diff_train] Fix OSS Spark modules to produce Java 8 bytecode after airbase 109 upgrade (#27416)#27416
Open
shelton408 wants to merge 1 commit into
Open
[presto][diff_train] Fix OSS Spark modules to produce Java 8 bytecode after airbase 109 upgrade (#27416)#27416shelton408 wants to merge 1 commit into
shelton408 wants to merge 1 commit into
Conversation
Contributor
|
shelton408
added a commit
to shelton408/presto
that referenced
this pull request
Mar 24, 2026
… after airbase 109 upgrade (prestodb#27416) Summary: [prestodb#27130](prestodb#27130) (meta internal revision D96822883) bumped airlift airbase from v108 to v109, which sets `project.build.targetJdk=17` by default. Airbase configures `maven-compiler-plugin` with `<source>${project.build.targetJdk}</source>` and `<target>${project.build.targetJdk}</target>`, so all modules now produce Java 17 bytecode (class file version 61.0). The Spark launcher jar runs on Spark executors using Java 8, which only supports class file versions up to 52.0. This causes `UnsupportedClassVersionError` at startup, surfacing as `WRAPPER_ERROR_UNKNOWN` in Sapphire QueryBank runs. This diff overrides `maven-compiler-plugin` to target Java 8 in the two OSS modules that end up on the Spark classpath: - `presto-spark-launcher` - `presto-spark-classloader-interface` Differential Revision: D97804331
45aa8aa to
029c129
Compare
… after airbase 109 upgrade (prestodb#27416) Summary: [prestodb#27130](prestodb#27130) (meta internal revision D96822883) bumped airlift airbase from v108 to v109, which sets `project.build.targetJdk=17` by default. Airbase configures `maven-compiler-plugin` with `<source>${project.build.targetJdk}</source>` and `<target>${project.build.targetJdk}</target>`, so all modules now produce Java 17 bytecode (class file version 61.0). The Spark launcher jar runs on Spark executors using Java 8, which only supports class file versions up to 52.0. This causes `UnsupportedClassVersionError` at startup, surfacing as `WRAPPER_ERROR_UNKNOWN` in Sapphire QueryBank runs. This diff overrides `maven-compiler-plugin` to target Java 8 in the two OSS modules that end up on the Spark classpath: - `presto-spark-launcher` - `presto-spark-classloader-interface` Differential Revision: D97804331
029c129 to
2b324c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#27130 (meta internal revision D96822883) bumped airlift airbase from v108 to v109, which sets
project.build.targetJdk=17by default. Airbase configuresmaven-compiler-pluginwith<source>${project.build.targetJdk}</source>and
<target>${project.build.targetJdk}</target>, so all modules nowproduce Java 17 bytecode (class file version 61.0).
The Spark launcher jar runs on Spark executors using Java 8, which only
supports class file versions up to 52.0. This causes
UnsupportedClassVersionErrorat startup, surfacing asWRAPPER_ERROR_UNKNOWNin Sapphire QueryBank runs.This diff overrides
maven-compiler-pluginto target Java 8 in the twoOSS modules that end up on the Spark classpath:
presto-spark-launcherpresto-spark-classloader-interfaceDifferential Revision: D97804331