Use custom codecs in TPCH#26650
Draft
tdcmeehan wants to merge 3 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Sorry @tdcmeehan, your pull request is larger than the review limit of 150000 diff characters
Add support for binary deserialization of connector handles through the ConnectorProtocol interface. This enables connectors to provide custom binary deserialization alongside the existing JSON support.
Add binary deserialization for TPCH connector handles in C++ to match the Java serialization format. Includes TpchPrestoToVeloxConnector for converting protocol objects to Velox representations.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 22, 2026
…ization Port binary deserialization routing from Tim's PR prestodb#26650 (commit 0ee0f05) and extend it to cover all 5 handle types in both code paths: - .cpp.inc files (Thrift deserialization path) - from PR prestodb#26650 - presto_protocol_core.cpp (JSON from_json path) - new addition The JSON from_json path was missing: when Java sends handles with customSerializedValue (binary serialization via Base64), the C++ side fell through to getConnectorProtocol(type).from_json() which is NYI for custom connectors like CLP. Also includes ConnectorProtocol.h/.h changes adding serialize/deserialize virtual methods and ColumnHandle serialize/deserialize stubs.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 22, 2026
…ization Port binary deserialization routing from Tim's PR prestodb#26650 (commit 0ee0f05) and extend it to cover all 5 handle types in both code paths: - .cpp.inc files (Thrift deserialization path) - from PR prestodb#26650 - presto_protocol_core.cpp (JSON from_json path) - new addition The JSON from_json path was missing: when Java sends handles with customSerializedValue (binary serialization via Base64), the C++ side fell through to getConnectorProtocol(type).from_json() which is NYI for custom connectors like CLP. Also includes ConnectorProtocol.h/.h changes adding serialize/deserialize virtual methods and ColumnHandle serialize/deserialize stubs.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 22, 2026
…e types Add customSerializedValue routing in from_json() for the 5 remaining connector handle types from Tim's PR prestodb#26650: - ConnectorDeleteTableHandle - ConnectorIndexHandle - ConnectorInsertTableHandle - ConnectorOutputTableHandle - ConnectorPartitioningHandle
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 22, 2026
Ports customSerializedValue routing from prestodb#26650 (0ee0f05) for: ConnectorDeleteTableHandle, ConnectorIndexHandle, ConnectorInsertTableHandle, ConnectorOutputTableHandle, ConnectorPartitioningHandle.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 22, 2026
Ports customSerializedValue routing from prestodb#26650 (0ee0f05) for: ConnectorDeleteTableHandle, ConnectorIndexHandle, ConnectorInsertTableHandle, ConnectorOutputTableHandle, ConnectorPartitioningHandle.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 22, 2026
Ports customSerializedValue routing from prestodb#26650 (0ee0f05) for: ConnectorDeleteTableHandle, ConnectorIndexHandle, ConnectorInsertTableHandle, ConnectorOutputTableHandle, ConnectorPartitioningHandle.
20001020ycx
added a commit
to 20001020ycx/presto
that referenced
this pull request
Apr 27, 2026
…ch style Rename ClpCodecProvider → ClpConnectorCodecProvider to follow Tim's TpchConnectorCodecProvider naming convention. Consolidate all 5 codec classes into inner static classes within a single file. Adopt Tim's variable naming style (cast to type-specific variable) and error handling pattern (UncheckedIOException with plain try blocks). Follows the approach proposed in prestodb#26650.
3 tasks
20001020ycx
added a commit
to 20001020ycx/presto
that referenced
this pull request
Apr 27, 2026
Move each codec class out of ClpConnectorCodecProvider into its own file. ClpConnectorCodecProvider now only provides the connector-level factory methods. Each codec still follows Tim's style from prestodb#26650 (cast to type-specific variable, UncheckedIOException, plain try).
3 tasks
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 29, 2026
Implement binary deserialization for all 5 CLP connector handle types (ClpColumnHandle, ClpSplit, ClpTableHandle, ClpTableLayoutHandle, ClpTransactionHandle) by inheriting ConnectorProtocol and overriding deserialize(). Reads binary bytes (Java DataOutputStream big-endian wire format from #158) directly into existing protocol structs using std::istringstream and folly::Endian::big. Follows Tim's TpchConnectorProtocol pattern from prestodb#26650.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 30, 2026
Implement binary deserialization for all 5 CLP connector handle types (ClpColumnHandle, ClpSplit, ClpTableHandle, ClpTableLayoutHandle, ClpTransactionHandle) by inheriting ConnectorProtocol and overriding deserialize(). Reads binary bytes (Java DataOutputStream big-endian wire format from #158) directly into existing protocol structs using std::istringstream and folly::Endian::big. Follows Tim's TpchConnectorProtocol pattern from prestodb#26650.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 30, 2026
Implement binary deserialization for all 5 CLP connector handle types (ClpColumnHandle, ClpSplit, ClpTableHandle, ClpTableLayoutHandle, ClpTransactionHandle) by inheriting ConnectorProtocol and overriding deserialize(). Reads binary bytes (Java DataOutputStream big-endian wire format from #158) directly into existing protocol structs using std::istringstream and folly::Endian::big. Follows Tim's TpchConnectorProtocol pattern from prestodb#26650.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 30, 2026
Implement binary deserialization for all 5 CLP connector handle types (ClpColumnHandle, ClpSplit, ClpTableHandle, ClpTableLayoutHandle, ClpTransactionHandle) by inheriting ConnectorProtocol and overriding deserialize(). Reads binary bytes (Java DataOutputStream big-endian wire format from #158) directly into existing protocol structs using std::istringstream and folly::Endian::big. Follows Tim's TpchConnectorProtocol pattern from prestodb#26650.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 30, 2026
Implement binary deserialization for all 5 CLP connector handle types (ClpColumnHandle, ClpSplit, ClpTableHandle, ClpTableLayoutHandle, ClpTransactionHandle) by inheriting ConnectorProtocol and overriding deserialize(). Reads binary bytes (Java DataOutputStream big-endian wire format from #158) directly into existing protocol structs using std::istringstream and folly::Endian::big. Follows Tim's TpchConnectorProtocol pattern from prestodb#26650.
20001020ycx
added a commit
to y-scope/presto
that referenced
this pull request
Apr 30, 2026
Implement binary deserialization for all 5 CLP connector handle types (ClpColumnHandle, ClpSplit, ClpTableHandle, ClpTableLayoutHandle, ClpTransactionHandle) by inheriting ConnectorProtocol and overriding deserialize(). Reads binary bytes (Java DataOutputStream big-endian wire format from #158) directly into existing protocol structs using std::istringstream and folly::Endian::big. Follows Tim's TpchConnectorProtocol pattern from prestodb#26650.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: