Skip to content

Remove invalidate metastore cache procedure from iceberg#25787

Merged
pratyakshsharma merged 1 commit into
prestodb:masterfrom
pratyakshsharma:iceberg-metastore-cache
Aug 16, 2025
Merged

Remove invalidate metastore cache procedure from iceberg#25787
pratyakshsharma merged 1 commit into
prestodb:masterfrom
pratyakshsharma:iceberg-metastore-cache

Conversation

@pratyakshsharma

Copy link
Copy Markdown
Contributor

Description

Now that metastore cache is no longer supported for iceberg, we do not need to have system.invalidate_metastore_cache procedure for iceberg either.

Motivation and Context

Support for metastore cache for iceberg was removed in this PR #24326

Impact

Users no longer have system.invalidate_metastore_cache procedure for iceberg connector.

Test Plan

NA

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Aug 14, 2025
@prestodb-ci prestodb-ci requested review from a team, Dilli-Babu-Godari and anandamideShakyan and removed request for a team August 14, 2025 10:38

@hantangwangd hantangwangd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratyakshsharma pratyakshsharma force-pushed the iceberg-metastore-cache branch from cf82dae to e05838e Compare August 14, 2025 16:09
@pratyakshsharma pratyakshsharma merged commit 85e87a2 into prestodb:master Aug 16, 2025
67 checks passed
pratyakshsharma added a commit that referenced this pull request Apr 28, 2026
## Description
Enable metastore cache invalidation procedure for Iceberg connector now
that metastore cache is enabled for iceberg connector as part of #26918.
The check for this procedure was removed in
#25787.

## Motivation and Context
Metastore cache invalidation procedure can be enabled for iceberg
connector now.

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan
NA

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).

## Summary by Sourcery

New Features:
- Conditionally register the metastore cache invalidation procedure for
the Iceberg connector based on metastore client configuration.

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== RELEASE NOTES ==

Iceberg Connector Changes
* Add metastore cache invalidation procedure for Iceberg connector
```
msmygit pushed a commit to msmygit/presto that referenced this pull request Jun 3, 2026
## Description
Enable metastore cache invalidation procedure for Iceberg connector now
that metastore cache is enabled for iceberg connector as part of prestodb#26918.
The check for this procedure was removed in
prestodb#25787.

## Motivation and Context
Metastore cache invalidation procedure can be enabled for iceberg
connector now.

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan
NA

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).

## Summary by Sourcery

New Features:
- Conditionally register the metastore cache invalidation procedure for
the Iceberg connector based on metastore client configuration.

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== RELEASE NOTES ==

Iceberg Connector Changes
* Add metastore cache invalidation procedure for Iceberg connector
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants